Bug #36515: Module does not load in IE8 / IE9 - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #36515

closed

Module does not load in IE8 / IE9

Added by Heinz Schilling over 12 years ago. Updated about 7 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Daniel Minder

Category:

Linkvalidator

Target version:

4.7.11

Start date:

2012-04-24

Due date:

% Done:

100%

Estimated time:

3.00 h

TYPO3 Version:

4.5

PHP Version:

5.3

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

Internet Explorer 8 and IE 9 does not load the Linkvalidator in TYPO3 4.5.11 / 4.5.15 with JavaScript Error.

Benutzer-Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; InfoPath.3; .NET4.0C; .NET4.0E)
Zeitstempel: Tue, 24 Apr 2012 13:26:56 UTC

Meldung: 'events' ist Null oder kein Objekt
Zeile: 7
Zeichen: 163909
Code: 0
URI: http://<DOMAIN>/typo3temp/compressor/ext-all-8f7f9a813fa4e5dc4d4725737dbcecee.js.gzip

Files

checktab.diff (648 Bytes) checktab.diff

Daniel Minder, 2013-03-13 16:39

Actions

Copy link

Updated by Philipp Gampe over 12 years ago

Status changed from New to Needs Feedback

I tried with TYPO3 4.5.16-dev and all works fine. There were no changes in linkvalidator since 4.5.15.

Can you please try to clear the cache and check again?

Actions

Copy link

Updated by Heinz Schilling over 12 years ago

I updated the installation from 4.5.11 to 4.5.15 yesterday (sorry for the wrong information), but the problem exists further. All caches are cleared.

When I click on [0] root in page tree the linkvalidator module load in IE. When I click on a page in the tree the IE 8 and IE9 does not load with the JavaScript error.

Maybe the problem comes from the compression? This I configured in the installation:

$TYPO3_CONF_VARS['BE']['compressionLevel'] = '9';    //  Modified or inserted by TYPO3 Install Tool.

I try without compression next week.

Actions

Copy link

Updated by Heinz Schilling over 12 years ago

I think I found the problem. With this TSconfig

mod.linkvalidator.showCheckLinkTab = 0

the Validator Modul does not load when you click on a page in tree other than [0].

Can you see the error?

Actions

Copy link

Updated by Philipp Gampe over 12 years ago

Status changed from Needs Feedback to Accepted
Priority changed from Should have to Must have
PHP Version set to 5.3

OK, I can reproduce it now.

Actions

Copy link

Updated by Philipp Gampe over 12 years ago

I get the same error, but it is on the page (the linkvalidator frame).

Actions

Copy link

Updated by Heinz Schilling about 12 years ago

Does we have to move this issue somewhere else that it will be fixed sometimes? - maybe ;-)

Actions

Copy link

Updated by Philipp Gampe about 12 years ago

Just nag me once a week :P

I will see if I find someone during TYPO3 Camp Rhein Ruhr - my JS knowledge is pretty limited.

Actions

Copy link

Updated by Heinz Schilling over 11 years ago

Four months later it's me again. ;-) I'm the reminder for fixing this issue.

Actions

Copy link

Updated by Daniel Minder over 11 years ago

File checktab.diff checktab.diff added

This was quite complicated to figure out. Here is the whole story - in an understandable order, the actual debugging was of course different ;-)

First, I realized that it works in TYPO3 4.7 but not in 4.5 although the code for the TabPanel creation looks similar. However, if you open the developer tools in IE I saw that the standard document mode for the 4.5 backend is "IE 8" while for 4.7 it is "IE 9".

And indeed, there is a little difference in the interpretation of JavaScript in both modes :(

The "items" argument of the TabPanel is defined as "[ { autoHeight: ..., title: ..., html: ... }, ]" when showCheckLinkTab is set to 0. Note the "," after the closing }. In IE 9 mode this results in an array of length 1, but in IE 8 mode the array has length 2 with a second null element. And this second element causes the JavaScript error.

So, the solution is to simply remove this comma when no check link tab is displayed. See attached patch for TYPO3 4.5. Unfortunately, I don't have time now to create patches for other T3 versions (if necessary) and to push them to the review server.

Actions

Copy link

#10