Bug #36777

Unnecessary warning in css_styled_content (division by zero)

Added by Thomas Layh over 10 years ago. Updated almost 10 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Content Rendering
Target version:
Start date:
2012-05-02
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

PHP throws an unnecessary warning for the image scaling if some circumstances come together.

If you set the configuration

tt_content.image.20.maxW >

you will get a divison by zero warning. This happens because $netW becomes zero and after that $scale will have no value at all.

See the attached patch for details. Will push this to gerrit soon.


Files

#1

Updated by Gerrit Code Review over 10 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10928

#2

Updated by Thomas Layh over 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#3

Updated by Gerrit Code Review about 10 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/12076

#4

Updated by Gerrit Code Review about 10 years ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/12077

#5

Updated by Thomas Layh about 10 years ago

  • Status changed from Under Review to Resolved
#6

Updated by Rafal Brzeski about 10 years ago

What about TYPO3 4.5 ? The same thing are there.

#7

Updated by Gerrit Code Review about 10 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/12865

#8

Updated by Ernesto Baschny about 10 years ago

  • Category changed from Code Cleanup to Content Rendering
  • Status changed from Under Review to Resolved
  • Target version changed from 6.0.0 to 4.5.18
  • TYPO3 Version changed from 6.0 to 4.5
  • PHP Version deleted (5.3)
#9

Updated by Gerrit Code Review about 10 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/13154

#10

Updated by Gerrit Code Review about 10 years ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/13269

#11

Updated by Wouter Wolters almost 10 years ago

Please close this issue. All affected branches are up to date.

#12

Updated by Stefan Galinski almost 10 years ago

  • Status changed from Under Review to Closed

Also available in: Atom PDF