Task #36882

Change whitespaces in indentions into tabs

Added by Stefano Kowalke almost 9 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Category:
Linkvalidator
Target version:
-
Start date:
2012-05-06
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.7
PHP Version:
5.3
Tags:
Complexity:
Sprint Focus:

Description

Code have to indent by tabs. There are several places in the core where spaces was used. Change them into tabs.

How to check?

I assume PHP_CodeSniffer with the TYPO3v4 standard is installed at you machine, type in the console:

phpcs -v --standard=TYPO3v4 --sniffs=TYPO3.WhiteSpace.DisallowSpaceIndent --ignore=.git,typo3/sysext/openid/lib,typo3/contrib,typo3/sysext/adodb,typo3/sysext/em/mod1/class.nusoap.php,typo3/sysext/fluid,typo3/sysext/extbase,typo3/sysext/indexed_search/class.doublemetaphone.php --extensions=php,inc /Path/To/trunk/typo3/sysext/linkvalidator

before apply the patch. Than apply the patch and execute phpcs again. All the violations should be gone.
I did the changes manually to see if our sniff works correctly and we do not have some false positives. As far as I can see, it works very well. After merging the patch into core I will activate this sniff on ci.typo3.org for the gerrit and the nightly job.


Related issues

Related to TYPO3 Core - Task #36871: Change whitespaces in indentions into tabsClosedStefano Kowalke2012-05-06

Actions
#1

Updated by Gerrit Code Review almost 9 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11022

#2

Updated by Gerrit Code Review almost 9 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11022

#3

Updated by Stefano Kowalke almost 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Applied in changeset commit:ea6e60d357ab66f0b53eadbc2207b1a1a7907484.

#4

Updated by Gerrit Code Review almost 9 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch linkvalidator_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/11044

#5

Updated by Gerrit Code Review almost 9 years ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/11045

#6

Updated by Gerrit Code Review almost 9 years ago

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/11046

#7

Updated by Gerrit Code Review almost 9 years ago

Patch set 2 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/11046

#8

Updated by Stefano Kowalke almost 9 years ago

  • Status changed from Under Review to Resolved

Applied in changeset commit:62741ec3879eb332160326791dabb036a7336260.

#9

Updated by Michael Stucki about 7 years ago

  • Category set to Linkvalidator
#10

Updated by Michael Stucki about 7 years ago

  • Project changed from Linkvalidator to TYPO3 Core
  • Category changed from Linkvalidator to Linkvalidator
#11

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF