Project

General

Profile

Actions

Task #36871

closed

Change whitespaces in indentions into tabs

Added by Stefano Kowalke about 12 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Should have
Category:
Code Cleanup
Target version:
-
Start date:
2012-05-06
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.7
PHP Version:
5.3
Tags:
Complexity:
Sprint Focus:

Description

Code have to indent by tabs. There are several places in the core where spaces was used. Change them into tabs.

How to check?
I assume PHP_CodeSniffer with the TYPO3v4 standard is installed at you machine, type in the console:
phpcs -v --standard=TYPO3v4 --sniffs=TYPO3.WhiteSpace.DisallowSpaceIndent --ignore=.git,typo3/sysext/openid/lib,typo3/contrib,typo3/sysext/adodb,typo3/sysext/em/mod1/class.nusoap.php,typo3/sysext/fluid,typo3/sysext/extbase,typo3/sysext/indexed_search/class.doublemetaphone.php --extensions=php,inc /Path/To/trunk/

before apply the patch. Than apply the patch and execute phpcs again. All the violations should be gone.

I did the changes manually to see if our sniff works correctly and we do not have some false positives. As far as I can see, it works very well. After merging the patch into core I will activate this sniff on ci.typo3.org for the gerrit and the nightly job.


Related issues 5 (0 open5 closed)

Related to TYPO3 Core - Task #36882: Change whitespaces in indentions into tabsClosedStefano Kowalke2012-05-06

Actions
Related to TYPO3 Core - Task #36880: Change whitespaces in indentions into tabsClosedStefano Kowalke2012-05-06

Actions
Related to TYPO3 Core - Task #36884: Change whitespaces in indentions into tabs (Sysext: Workspaces)ClosedStefano Kowalke2012-05-06

Actions
Related to TYPO3 Core - Task #36883: Change whitespaces in indentions into tabs (Sysext: Version)ClosedStefano Kowalke2012-05-06

Actions
Precedes TYPO3 Core - Task #37020: Change whitespaces in indentions into tabs [Follow-up]ClosedStefano Kowalke2012-05-09

Actions
Actions #1

Updated by Gerrit Code Review about 12 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11018

Actions #2

Updated by Gerrit Code Review about 12 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11018

Actions #3

Updated by Stefano Kowalke about 12 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #4

Updated by Gerrit Code Review about 12 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11128

Actions #5

Updated by Gerrit Code Review about 12 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11128

Actions #6

Updated by Thorsten Kahler about 12 years ago

  • Status changed from Under Review to Resolved
Actions #7

Updated by Benni Mack almost 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF