Bug #36981: Regression of "better condition in versionOL of t3lib_tstemplate" (#31139) - TYPO3 Core - TYPO3 Forge

Actions

Bug #36981

closed

Regression of "better condition in versionOL of t3lib_tstemplate" (#31139)

Added by Andy Grunwald over 12 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Category:

Frontend

Target version:

-

Start date:

2012-05-09

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

4.5

PHP Version:

5.3

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

In bug #31139: "better condition in versionOL of t3lib_tstemplate", the commit / change produces a regression.

The line

if (is_object($GLOBALS['TSFE'])) { // Frontend:

was changed to

if (TYPO3_MODE === 'FE') { // Frontend:

This change cause an error, because not in every case in TYPO3_MODE FE is a full blown frontend available. One example is an eID.
An eID is TYPO3_MODE === 'FE' but there is no $GLOBALS['TSFE']->sys_page.
The following error occur:

Fatal error: Call to a member function versionOL() on a non-object in /var/www/dasgastroportal.dus.wmdb.de/typo3_src-4.5.15/t3lib/class.t3lib_tstemplate.php on line 753

In our case we create via direct_mail api new mailings via an eid.
Direct mail calls this method to get the correct charset for this page.

I will provide a patch for all four branches 4.5, 4.6, 4.7 and 6.0

Related issues 1 (0 open — 1 closed)

Actions

#1

Updated by Andy Grunwald over 12 years ago

Assignee set to Andy Grunwald

Actions

#2

Updated by Andy Grunwald over 12 years ago

I`m currently working on it.

Actions

#3

Updated by Gerrit Code Review over 12 years ago

Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11096

Actions

#4

Updated by Gerrit Code Review over 12 years ago

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/11097

Actions

#5

Updated by Gerrit Code Review over 12 years ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/11098

Actions

#6

Updated by Gerrit Code Review over 12 years ago

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/11099

Actions

#7

Updated by Gerrit Code Review over 12 years ago

Patch set 2 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/11098

Actions

#8

Updated by Andy Grunwald over 12 years ago

So, here we go.
four new patches for all affected branched in Gerrit.

Actions

#9

Updated by Gerrit Code Review over 12 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11096

Actions

#10

Updated by Gerrit Code Review over 12 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11096

Actions

#11

Updated by Gerrit Code Review over 12 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11096

Actions

#12

Updated by Gerrit Code Review over 12 years ago

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/11320

Actions

#13

Updated by Gerrit Code Review over 12 years ago

Patch set 2 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/11099

Actions

#14

Updated by Gerrit Code Review over 12 years ago

Patch set 3 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/11098

Actions

#15

Updated by Gerrit Code Review over 12 years ago

Patch set 2 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/11097

Actions

#16

Updated by Andy Grunwald over 12 years ago

Status changed from Under Review to Resolved
% Done changed from 0 to 100

Applied in changeset 4163ef3b917915141c716c8800932aa1eb604d75.

Actions

#17

Updated by Gerrit Code Review over 12 years ago

Status changed from Resolved to Under Review

Patch set 3 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/11099

Actions

#18

Updated by Gerrit Code Review over 12 years ago

Patch set 4 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/11098

Actions

#19

Updated by Gerrit Code Review over 12 years ago

Patch set 3 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/11097

Actions

#20

Updated by Andy Grunwald over 12 years ago

Status changed from Under Review to Resolved

Applied in changeset 1125e3dd0de9ac6d626a05ced701904b2b56a97e.

Actions

#21

Updated by Gerrit Code Review over 12 years ago

Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/13142

Actions

#22

Updated by Gerrit Code Review over 12 years ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/13258

Actions

#23

Updated by Helmut Hummel about 12 years ago

Status changed from Under Review to Resolved

Actions

#24

Updated by Benni Mack about 6 years ago

Status changed from Resolved to Closed

Actions

Also available in: Atom PDF