Bug #36981

Regression of "better condition in versionOL of t3lib_tstemplate" (#31139)

Added by Andy Grunwald almost 9 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
Frontend
Target version:
-
Start date:
2012-05-09
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

In bug #31139: "better condition in versionOL of t3lib_tstemplate", the commit / change produces a regression.

The line

if (is_object($GLOBALS['TSFE'])) { // Frontend:

was changed to

if (TYPO3_MODE === 'FE') { // Frontend:

This change cause an error, because not in every case in TYPO3_MODE FE is a full blown frontend available. One example is an eID.
An eID is TYPO3_MODE === 'FE' but there is no $GLOBALS['TSFE']->sys_page.
The following error occur:

Fatal error: Call to a member function versionOL() on a non-object in /var/www/dasgastroportal.dus.wmdb.de/typo3_src-4.5.15/t3lib/class.t3lib_tstemplate.php on line 753

In our case we create via direct_mail api new mailings via an eid.
Direct mail calls this method to get the correct charset for this page.

I will provide a patch for all four branches 4.5, 4.6, 4.7 and 6.0


Related issues

Related to TYPO3 Core - Bug #31139: better condition in versionOL of t3lib_tstemplateClosed2011-10-20

Actions
#1

Updated by Andy Grunwald almost 9 years ago

  • Assignee set to Andy Grunwald
#2

Updated by Andy Grunwald almost 9 years ago

I`m currently working on it.

#3

Updated by Gerrit Code Review almost 9 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11096

#4

Updated by Gerrit Code Review almost 9 years ago

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/11097

#5

Updated by Gerrit Code Review almost 9 years ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/11098

#6

Updated by Gerrit Code Review almost 9 years ago

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/11099

#7

Updated by Gerrit Code Review almost 9 years ago

Patch set 2 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/11098

#8

Updated by Andy Grunwald almost 9 years ago

So, here we go.
four new patches for all affected branched in Gerrit.

#9

Updated by Gerrit Code Review almost 9 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11096

#10

Updated by Gerrit Code Review almost 9 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11096

#11

Updated by Gerrit Code Review almost 9 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11096

#12

Updated by Gerrit Code Review almost 9 years ago

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/11320

#13

Updated by Gerrit Code Review almost 9 years ago

Patch set 2 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/11099

#14

Updated by Gerrit Code Review almost 9 years ago

Patch set 3 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/11098

#15

Updated by Gerrit Code Review almost 9 years ago

Patch set 2 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/11097

#16

Updated by Andy Grunwald almost 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#17

Updated by Gerrit Code Review almost 9 years ago

  • Status changed from Resolved to Under Review

Patch set 3 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/11099

#18

Updated by Gerrit Code Review almost 9 years ago

Patch set 4 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/11098

#19

Updated by Gerrit Code Review almost 9 years ago

Patch set 3 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/11097

#20

Updated by Andy Grunwald almost 9 years ago

  • Status changed from Under Review to Resolved
#21

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/13142

#22

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/13258

#23

Updated by Helmut Hummel over 8 years ago

  • Status changed from Under Review to Resolved
#24

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF