Project

General

Profile

Actions

Bug #37493

closed

t3lib_tcemain methods lack proper visibility settings

Added by Tolleiv Nietsch about 12 years ago. Updated over 8 years ago.

Status:
Rejected
Priority:
Should have
Category:
-
Target version:
Start date:
2012-05-25
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
6.0
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The patch changes as much methods as possible to "protected" only methods which are in use from the outside or which are called through callback-functions are left public.

Why so restrictive? The less we open up the more can be moved / refactored later.

Actions #1

Updated by Tolleiv Nietsch about 12 years ago

Test by using the backend as editor, create, edit, delete content within the LIVE and a draft workspace. Use the history, translate contents, ... and last but not least run the few unittests.

Actions #2

Updated by Gerrit Code Review about 12 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11624

Actions #3

Updated by Gerrit Code Review about 12 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11624

Actions #4

Updated by Gerrit Code Review about 12 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11624

Actions #5

Updated by Gerrit Code Review about 12 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11624

Actions #6

Updated by Gerrit Code Review about 12 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11624

Actions #7

Updated by Gerrit Code Review about 12 years ago

Patch set 6 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11624

Actions #8

Updated by Alexander Opitz almost 11 years ago

  • Status changed from Under Review to New

Patch was abandoned, see mailinglist for more information: http://lists.typo3.org/pipermail/typo3-team-core/2012-June/051679.html

Actions #9

Updated by Mathias Schreiber over 9 years ago

  • Target version set to 8 LTS
  • Is Regression set to No
Actions #10

Updated by Mathias Schreiber over 8 years ago

  • Status changed from New to Rejected

Jup, you're right, but this is basically stating the obvious

Actions

Also available in: Atom PDF