Project

General

Profile

Actions

Bug #37497

closed

t3lib_tcemain member variables lack proper visibility settings

Added by Tolleiv Nietsch about 12 years ago. Updated over 8 years ago.

Status:
Rejected
Priority:
Should have
Assignee:
-
Category:
-
Target version:
Start date:
2012-05-26
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
6.0
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The patch changes as much member variables as possible to "protected" only the ones which are in use from the outside are left public.

Why so restrictive? The less we open up the more can be moved / refactored later. From what I found even internal variables are used at the moment and as long as there's no technical restriction this might continue.

Actions #1

Updated by Gerrit Code Review about 12 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11635

Actions #2

Updated by Alexander Opitz almost 11 years ago

  • Status changed from Under Review to New

Patch was abandoned, see mailinglist for more information: http://lists.typo3.org/pipermail/typo3-team-core/2012-June/051679.html

Actions #3

Updated by Mathias Schreiber over 9 years ago

  • Target version set to 8 LTS
  • Is Regression set to No
Actions #4

Updated by Mathias Schreiber over 8 years ago

  • Status changed from New to Rejected

Jup, you're right, but this is basically stating the obvious

Actions

Also available in: Atom PDF