Bug #37612: felogin redirects to password reset after login - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #37612

closed

felogin redirects to password reset after login

Added by Markus Klein almost 12 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Jigal van Hemert

Category:

felogin

Target version:

Start date:

2012-05-30

Due date:

% Done:

Estimated time:

TYPO3 Version:

4.6

PHP Version:

5.3

Tags:

Complexity:

easy

Is Regression:

Sprint Focus:

Description

felogin redirects to password reset confirmation page after successful because "redirect to referer" is set in the plugin.

Fix this by skipping the referer input field when the url contains "tx_felogin_pi[forgotHash]".

Unfortunately this fix only works when the parameter is not beautified via URL rewriters like realurl.

Files

0001-BUGFIX-felogin-ignore-referer-after-forgot-password.patch (1.42 KB) 0001-BUGFIX-felogin-ignore-referer-after-forgot-password.patch

Markus Klein, 2012-05-30 16:15

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Markus Klein almost 12 years ago

Possible fix is:

class.tx_felogin_pi.php:

    // check for referer redirect method. if present, save referer in form field
if (t3lib_div::inList($this->conf['redirectMode'], 'referer') || t3lib_div::inList($this->conf['redirectMode'], 'refererDomains')) {
    $referer = $this->referer ? $this->referer : t3lib_div::getIndpEnv('HTTP_REFERER');
    if ($referer && strpos($referer, 'tx_felogin_pi1[forgotHash]') !== FALSE) {
        $extraHiddenAr[] = '<input type="hidden" name="referer" value="' . htmlspecialchars($referer) . '" />';
    }
}

by extending the condition in line 4.

Actions

Copy link

Updated by Markus Klein almost 12 years ago

File 0001-BUGFIX-felogin-ignore-referer-after-forgot-password.patch 0001-BUGFIX-felogin-ignore-referer-after-forgot-password.patch added

Actions

Copy link

Updated by Jigal van Hemert almost 12 years ago

Status changed from New to Needs Feedback
Assignee set to Jigal van Hemert
Complexity changed from nightmare to easy

I think this is a duplicate of #21943 , which was only applied to 6.0 and 4.7; unfortunately I haven't backported them to 4.6 and 4.5.

Markus, you reviewed the patch on 6.0 :-) Could you take care of the backports?

Actions

Copy link

Updated by Markus Klein almost 12 years ago

Damn it. I knew we had something like that already, but I didn't find it on forge as I searched only for open tickets, as I thought all the changes were already backported.

I'll of course do the backports right now.
Thanks Jigal!

Actions

Copy link