Bug #38403
closed
The log_data field in sys_log is too small, serialized data gets corrupted.
100%
Description
When adding a comment for a stage change in workspaces, this comment is stored in the log_data field of the sys_log table.
This field can only hold 255 characters. It is not unlikely that a comment is longer than 255 chars. If the field would only hold a comment then the issue would not be that severe, but the field holds a serialized array with other data as well. This other data (a.g. stage id) is corrupted or lost when a long comment is entered.
Suggested fix: change the field to TEXT and also limit the amount characters that can be entered at the stage change in workspaces.
Holds for 4.5 up till 6.0.
Updated by Bart Dubelaar over 12 years ago
How to reproduce:
1: Make a change in a draft workspace
2: Open the workspaces module and send the changed record to another stage.
3: In the notification popup, enter a comment of 250 characters (you can generate a piece of text of 250 bytes at www.lipsum.com).
4: Click ok to send to next stage end now click on the record, you will see that the comment you just typed is not shwown. Additionally the stage change info box will always show "@ Stage Editing" regardless of the originating stage.
Updated by Gerrit Code Review over 12 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13531
Updated by Bart Dubelaar over 12 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset b02859be3dad7d56a90ac529c5fde84e0c8b26cf.
Updated by