Bug #38472: Remove HTML in RuntimeException from sysext 'install' - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #38472

closed

Remove HTML in RuntimeException from sysext 'install'

Added by Simon Schick almost 12 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Target version:

6.0.0-alpha3

Start date:

2012-06-29

Due date:

% Done:

100%

Estimated time:

0.25 h

TYPO3 Version:

6.0

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

Hi, all

I tried out the latest Alpha and since I have not installed the gd-extension for PHP I got an error for that.

The text of this error looked like this (that's what I got in the browser):

#1294587482: TYPO3 Installation Error: The following PHP module(s) is/are missing: <em>gd</em><br /><br />You need to install and enable these modules first to be able to install TYPO3. (More information)

What I want you to do:
Please remove the HTML-tags like em and br in the exception-message in /typo3/sysext/install/mod/class.tx_install.php in (the code I have it's) line 203

Actions

Copy link

Updated by Philipp Gampe almost 12 years ago

Just place the <em> tags with double quotes and the <br> tags with real linefeeds (LN).

Actions

Copy link

Updated by Gerrit Code Review almost 12 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12477

Actions

Copy link

Updated by Philipp Gampe almost 12 years ago

Please move this to normal core tracker as this affects all branches from 4.5 upwards and has nothing to do with the bootstrap refactoring.

Actions

Copy link

Updated by Simon Schick almost 12 years ago

@Philipp:

The exception-message can contain a list of missing plugins ...

So the message you get may look like this after applying your patch if the extensions foo and bar are missing:

#1294587482: TYPO3 Installation Error: The following PHP module(s) is/are missing: "foo, bar" You need to install and enable these modules first to be able to install TYPO3. (More information)

I think the implode() function has to be updated as well, that every extension-name is surrounded by quotation marks.

Actions

Copy link

Updated by Philipp Gampe almost 12 years ago

I am aware of this. To me it does not matter ... please post your review to gerrit too. That way, others do overlook your comment. You can use your normal T3o login details to long in review.typo3.org.

Actions

Copy link