Bug #38472

Remove HTML in RuntimeException from sysext 'install'

Added by Simon Schick almost 9 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
Start date:
2012-06-29
Due date:
% Done:

100%

Estimated time:
0.25 h
TYPO3 Version:
6.0
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Hi, all

I tried out the latest Alpha and since I have not installed the gd-extension for PHP I got an error for that.

The text of this error looked like this (that's what I got in the browser):

#1294587482: TYPO3 Installation Error: The following PHP module(s) is/are missing: <em>gd</em><br /><br />You need to install and enable these modules first to be able to install TYPO3. (More information)

What I want you to do:
Please remove the HTML-tags like em and br in the exception-message in /typo3/sysext/install/mod/class.tx_install.php in (the code I have it's) line 203

#1

Updated by Philipp Gampe almost 9 years ago

Just place the <em> tags with double quotes and the <br> tags with real linefeeds (LN).

#2

Updated by Gerrit Code Review almost 9 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12477

#3

Updated by Philipp Gampe almost 9 years ago

Please move this to normal core tracker as this affects all branches from 4.5 upwards and has nothing to do with the bootstrap refactoring.

#4

Updated by Simon Schick almost 9 years ago

@Philipp:

The exception-message can contain a list of missing plugins ...

So the message you get may look like this after applying your patch if the extensions foo and bar are missing:

#1294587482: TYPO3 Installation Error: The following PHP module(s) is/are missing: "foo, bar" You need to install and enable these modules first to be able to install TYPO3. (More information)

I think the implode() function has to be updated as well, that every extension-name is surrounded by quotation marks.

#5

Updated by Philipp Gampe almost 9 years ago

I am aware of this. To me it does not matter ... please post your review to gerrit too. That way, others do overlook your comment. You can use your normal T3o login details to long in review.typo3.org.

#6

Updated by Helmut Hummel almost 9 years ago

  • Project changed from Refactoring Bootstrap to TYPO3 Core
#7

Updated by Helmut Hummel almost 9 years ago

  • Target version set to 6.0.0-alpha3
#8

Updated by Gerrit Code Review over 8 years ago

  • Status changed from New to Under Review

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12477

#9

Updated by Gerrit Code Review over 8 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12477

#10

Updated by Gerrit Code Review over 8 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12477

#11

Updated by Gerrit Code Review over 8 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12477

#12

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at http://review.typo3.org/17004

#13

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/17005

#14

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/17006

#15

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/17007

#16

Updated by Philipp Gampe over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#17

Updated by Riccardo De Contardi over 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF