Project

General

Profile

Actions

Bug #38652

closed

RTE spell checker is flooding directory typo3temp on Windows

Added by Gerhard Rupp over 12 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Should have
Category:
RTE (rtehtmlarea + ckeditor)
Target version:
Start date:
2012-07-04
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

As the spell checker in TYPO3 creates one *.tmp file for every single word of a text the typo3temp directory is crowded of files. The temporary files should be deleted after spell checking was completed.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #38699: t3lib_div::unlink_tempfile does not always work on WindowsClosedStanislas Rolland2012-07-06

Actions
Actions #1

Updated by Stanislas Rolland over 12 years ago

  • Category set to RTE (rtehtmlarea + ckeditor)
Actions #2

Updated by Stanislas Rolland over 12 years ago

The files are indeed deleted with t3lib_div::unlink_tempfile()...

I am unable to reproduce this issue.

Maybe on Windows the file is not deleted if not closed...

Actions #3

Updated by Stanislas Rolland over 12 years ago

  • Subject changed from Spell checker is flooding directory typo3temp to RTE spell checker is flooding directory typo3temp on Windows
  • Assignee set to Stanislas Rolland
  • Target version set to 4.5.18
  • PHP Version set to 5.3
Actions #4

Updated by Gerrit Code Review over 12 years ago

  • Status changed from New to Under Review

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/12643

Actions #5

Updated by Stanislas Rolland over 12 years ago

Please test this change on a Windows server: http://review.typo3.org/12643

Actions #6

Updated by Gerhard Rupp over 12 years ago

Even with the patched version the files remain in the temp directory.

Actions #7

Updated by Gerrit Code Review over 12 years ago

Patch set 2 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/12643

Actions #8

Updated by Stanislas Rolland over 12 years ago

Please test the second patch set.

Will be running out of ideas: http://ca2.php.net/manual/en/function.unlink.php

Actions #9

Updated by Gerhard Rupp over 12 years ago

Patch 2 didn´t work either.

Actions #10

Updated by Gerhard Rupp over 12 years ago

The problem is related to windows path names containing backslashes.

Replacing the backslashes by adding

$tmpFileName = str_replace('\\', '/', $tmpFileName);

does the job.

But I think this replacement should be done in the unlink_tempfile function.

Actions #11

Updated by Stanislas Rolland over 12 years ago

Please test this change and give your vote in gerrit: http://review.typo3.org/12684

Actions #12

Updated by Gerhard Rupp over 12 years ago

Should this work under 4.5?

Actions #13

Updated by Stanislas Rolland over 12 years ago

Gerhard Rupp wrote:

Should this work under 4.5?

I think so.

Actions #14

Updated by Gerhard Rupp over 12 years ago

I can´t get it running under 4.5. If I only replace the function unlink_tempfile everything is fine.

Actions #15

Updated by Stanislas Rolland over 12 years ago

Gerhard Rupp wrote:

I can´t get it running under 4.5. If I only replace the function unlink_tempfile everything is fine.

Here is the same change for TYPO3 4.5: http://review.typo3.org/12754

Actions #16

Updated by Gerhard Rupp over 12 years ago

I can confirm that this patch works on a windows server on TYPO3 4.5.18.

Actions #17

Updated by Stanislas Rolland about 12 years ago

  • Target version changed from 4.5.18 to 4.5.21
Actions #18

Updated by Stanislas Rolland about 12 years ago

  • Status changed from Under Review to Resolved
Actions #19

Updated by Riccardo De Contardi about 7 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF