Feature #38742
closed
indexed_search performance: function submitWords with exec_INSERTmultipleRows
100%
Description
On different systems I had performance issues with indexed_search due to a vast number of single INSERT queries generated by function submitWords() in class.indexer.php. On different occasions those queries resulted in a bottleneck in disk I/O. Last time that happened was on a system with ext4 filesystem using mount option "barrier" (default settings in CentOS 6).
Looking at the code of submitWords() I suppose it would help to conflate all queries for a given 'phash' using TYPO3 function exec_INSERTmultipleRows() instead of exec_INSERTquery(). (At least when using a MySQL backend and not using dbal.)
Attached you find a patch against class.indexer.php (taken from TYPO3 4.7.1). Unfortunately I had no opportunity to test my patch -- though I think it should work.
What do you think about my suggestion?
Best regards
Christian
Files
Updated by Christian Bartolomaeus almost 12 years ago
Is there anything I could do to get this feature request implemented?
I think the change would make a substantial difference in some (common) situations. Do you think otherwise or was it just lack of time why there was no response?
Best regards
Christian
Updated by Ralf Hettinger about 11 years ago
Being in a similar situation here. After testing the patch I can confirm that this is indeed a game changer regarding indexing performance.
A big +1, will push it to git now which might hopefully help getting it implemented.
Updated by Gerrit Code Review about 11 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20275
Updated by Gerrit Code Review about 11 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20275
Updated by Gerrit Code Review almost 11 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20275
Updated by Gerrit Code Review almost 10 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/20275
Updated by Gerrit Code Review almost 10 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/20275
Updated by Gerrit Code Review almost 10 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/20275
Updated by Gerrit Code Review almost 10 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/20275
Updated by Anonymous over 9 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 25633627e6826ba9acf18870bb75d30ae62d7c8b.
Updated by