Feature #38742
closed
indexed_search performance: function submitWords with exec_INSERTmultipleRows
Added by Christian Bartolomaeus over 12 years ago.
Updated about 6 years ago.
Description
On different systems I had performance issues with indexed_search due to a vast number of single INSERT queries generated by function submitWords() in class.indexer.php. On different occasions those queries resulted in a bottleneck in disk I/O. Last time that happened was on a system with ext4 filesystem using mount option "barrier" (default settings in CentOS 6).
Looking at the code of submitWords() I suppose it would help to conflate all queries for a given 'phash' using TYPO3 function exec_INSERTmultipleRows() instead of exec_INSERTquery(). (At least when using a MySQL backend and not using dbal.)
Attached you find a patch against class.indexer.php (taken from TYPO3 4.7.1). Unfortunately I had no opportunity to test my patch -- though I think it should work.
What do you think about my suggestion?
Best regards
Christian
Files
|
patch (1.06 KB)
patch |
patch for class.indexer.php |
Christian Bartolomaeus, 2012-07-08 09:56
|
|
Is there anything I could do to get this feature request implemented?
I think the change would make a substantial difference in some (common) situations. Do you think otherwise or was it just lack of time why there was no response?
Best regards
Christian
Being in a similar situation here. After testing the patch I can confirm that this is indeed a game changer regarding indexing performance.
A big +1, will push it to git now which might hopefully help getting it implemented.
- Status changed from New to Under Review
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/20275
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/20275
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/20275
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/20275
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
- Status changed from Resolved to Closed
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by 
Updated by Anonymous 
Updated by