Bug #39563

Regression in t3lib_iconWorks::imagecopyresized

Added by Tymoteusz Motylewski over 7 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2012-08-06
Due date:
% Done:

100%

TYPO3 Version:
6.0
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Revision 98f73d8b (issue #26660, review [1]) introduced 2 regressions. One in
t3lib_stdGraphic::imagecopyresized and the second one in t3lib_iconWorks::imagecopyresized.

First regression was already fixed in master [5] and v.4.7 [6] but the second one is still there. The problem itself is really no brainer - underlying function is called with wrong parameters.

This has to be fixed in 4.7 branch and master (6.0).
The original patch wasn't merged yet to 4.5 and 4.6, so bug can be fixed there.

Changes overview:
[1] https://review.typo3.org/#/c/2564/ - master, merged (original change)
[2] https://review.typo3.org/#/c/9608/ - v.4.7, merged
[3] https://review.typo3.org/#/c/6829/ - v.4.6, not merged
[4] https://review.typo3.org/#/c/6831/ - v.4.5, not merged

Regresion fixes:
[5] https://review.typo3.org/#/c/11984/ - master, merged (fix one regression)
[6] https://review.typo3.org/#/c/12074/ - 4.7, merged (fix one regression)


Related issues

Related to TYPO3 Core - Bug #26660: imagecopyresized has invalid function parameter Closed 2011-05-06
Related to TYPO3 Core - Bug #36947: GIFBUILDER render twice Closed 2012-05-08

Associated revisions

Revision 02ccc686 (diff)
Added by Tymoteusz Motylewski about 7 years ago

[BUGFIX] Regression in t3lib_iconWorks::imagecopyresized

t3lib_iconWorks::imagecopyresized was refactored
in #26660. Unfortunatelly that change introduced
a regression. Parameter names were changed in
the method definition, but not inside this method.

This change makes parameter names consistent.

Change-Id: I819da83ea059ecc7d17348c12ca64b37fac6dae0
Fixes: #39563
Releases: 6.0, 4.7
Reviewed-on: http://review.typo3.org/13488
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Revision 681aea54 (diff)
Added by Tymoteusz Motylewski about 7 years ago

[BUGFIX] Regression in t3lib_iconWorks::imagecopyresized

t3lib_iconWorks::imagecopyresized was refactored
in #26660. Unfortunatelly that change introduced
a regression. Parameter names were changed in
method definition, but inside this method.

This change makes parameter names consistent.

Change-Id: I819da83ea059ecc7d17348c12ca64b37fac6dae0
Fixes: #39563
Releases: 6.0, 4.7
Reviewed-on: http://review.typo3.org/13489
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

History

#1 Updated by Gerrit Code Review over 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13488

#2 Updated by Gerrit Code Review over 7 years ago

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/13489

#3 Updated by Stefan Neufeind over 7 years ago

Patches [3] and [4] mentioned here are not yet merged, but latest versions don't include that regression anymore.

#4 Updated by Gerrit Code Review about 7 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13488

#5 Updated by Gerrit Code Review about 7 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13488

#6 Updated by Tymoteusz Motylewski about 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF