Project

General

Profile

Actions
Copy link

Feature #39638

closed

respect box width and height in gifbuilder imagesize

Added by Kjeld Schumacher over 12 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Could have
Assignee:
-
Category:
Image Cropping
Target version:
-
Start date:
2012-08-09
Due date:
% Done:

0%

Estimated time:
PHP Version:
5.3
Tags:
Complexity:
Sprint Focus:

Description

Hi,

this feature adds the possibility to use the BOX width and height dimensions in gifbuilder imagesize calculation.

At this time TYPO3 does not take the dimensions into account due to the lack of the BoundingBox attribute in the gifbuilder calcOffset function.

The solution is pretty simple, add the missing BoundingBox attribute at the beginning of image creation. Just use the calcOffset function to calculate the BOX width and height and add the result to the BoundingBox attribute.

list($x, $y, $width, $height) = explode(',', $conf['dimensions']);
$this->objBB[$theKey] = explode(',', $this->calcOffset($width . ',' . $height));
break;

Actions
Copy link
 #1

Updated by Gerrit Code Review over 12 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13533

Actions
Copy link
 #2

Updated by Gerrit Code Review over 12 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13533

Actions
Copy link
 #3

Updated by Gerrit Code Review over 12 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13533

Actions
Copy link
 #4

Updated by Gerrit Code Review over 12 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13564

Actions
Copy link
 #5

Updated by Gerrit Code Review almost 12 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/13564

Actions
Copy link
 #6

Updated by Gerrit Code Review almost 12 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/13564

Actions
Copy link
 #7

Updated by Philipp Gampe almost 12 years ago

Do you have some sample TS to test the code?

Actions
Copy link
 #8

Updated by Gerrit Code Review over 11 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/13564

Actions
Copy link
 #9

Updated by Gerrit Code Review almost 10 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/13564

Actions
Copy link
 #10

Updated by Alexander Opitz about 9 years ago

  • Target version changed from 4.7.3 to 7.5

@Kjeld Schumacher

Can you please provide a new patch on Gerrit?

Actions
Copy link
 #11

Updated by Benni Mack about 9 years ago

  • Target version changed from 7.5 to 7 LTS
Actions
Copy link
 #12

Updated by Benni Mack about 9 years ago

  • Target version changed from 7 LTS to 8 LTS
Actions
Copy link
 #13

Updated by Gerrit Code Review about 9 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/13564

Actions
Copy link
 #14

Updated by Benni Mack almost 9 years ago

  • Status changed from Under Review to Needs Feedback

please repush a new version, if you're still interested in this change.

Actions
Copy link
 #15

Updated by Alexander Opitz over 8 years ago

  • Status changed from Needs Feedback to Closed
  • Target version deleted (8 LTS)

No feedback within the last 90 days => closing this issue.

If you think that this is the wrong decision or experience this issue again, then please write to the mailing list typo3.teams.bugs with issue number and an explanation or open a new ticket and add a relation to this ticket number.

Actions
Copy link

Also available in: Atom PDF