Bug #40280

Epic #65814: Make Indexed search extbase plugin shine

indexed_search pi2 (extbase/fluid): pointer setting not initialized in repository

Added by Andreas Kiessling about 7 years ago. Updated 12 months ago.

Status:
Closed
Priority:
Must have
Category:
Indexed Search
Target version:
-
Start date:
2012-08-27
Due date:
% Done:

100%

TYPO3 Version:
4.7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The resultsPerPage setting is not initialized which leads to a division by zero error. The needed data is available from the settings that the controller passes to the repository and probably just needs to be initialized.

indexed_search_pointer.patch View (1.91 KB) Andreas Kiessling, 2012-08-27 18:38

Associated revisions

Revision bdfa3b47 (diff)
Added by Tymoteusz Motylewski over 4 years ago

[BUGFIX] Indexed_search Make results per page work (Extbase plugin)

Replaces wrong setting "results" and uses "numberOfResults" instead.
Protects PageBrowskingViewHelper from division by zero warning.
Fix wrong path to the page_links setting in the template.

Resolves: #40280
Releases: master, 6.2
Change-Id: I6636c6796b92181dbe298562df2fb59a4f1f1ec2
Reviewed-on: http://review.typo3.org/38789
Reviewed-by: Tymoteusz Motylewski <>
Tested-by: Tymoteusz Motylewski <>

Revision e98532ba (diff)
Added by Tymoteusz Motylewski over 4 years ago

[BUGFIX] Indexed_search Make results per page work (Extbase plugin)

Replaces wrong setting "results" and uses "numberOfResults" instead.
Protects PageBrowskingViewHelper from division by zero warning.
Fix wrong path to the page_links setting in the template.

Resolves: #40280
Releases: master, 6.2
Change-Id: I6636c6796b92181dbe298562df2fb59a4f1f1ec2
Reviewed-on: http://review.typo3.org/39383
Reviewed-by: Wouter Wolters <>
Reviewed-by: Tymoteusz Motylewski <>
Tested-by: Tymoteusz Motylewski <>

History

#1 Updated by Artus Kolanowski almost 6 years ago

Why is this not already fixed? Without this patch the page browsing won't work at all...

#2 Updated by Artus Kolanowski almost 6 years ago

Hm but only numberOfResults affects the amount of results. So would it not be better to replace $resultsPerPage by $numberOfResults in your patch?

#3 Updated by Tymoteusz Motylewski over 4 years ago

  • Parent task set to #65814
  • Is Regression set to No

#4 Updated by Tymoteusz Motylewski over 4 years ago

  • Assignee set to Tymoteusz Motylewski

#5 Updated by Gerrit Code Review over 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38789

#6 Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38789

#7 Updated by Gerrit Code Review over 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38789

#8 Updated by Gerrit Code Review over 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38789

#9 Updated by Tymoteusz Motylewski over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#10 Updated by Gerrit Code Review over 4 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/39383

#11 Updated by Tymoteusz Motylewski over 4 years ago

  • Status changed from Under Review to Resolved

#12 Updated by Benni Mack 12 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF