Project

General

Profile

Actions
Copy link

Bug #41719

closed

Bad comparison for strings

Added by Dmitry Dulepov over 11 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Andreas Wolf
Category:
File Abstraction Layer (FAL)
Target version:
6.0.0-RC1
Start date:
2012-10-08
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.0
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

ResourceStorage:

        if (in_array($action, array('read'))) {

There is no need for in_array() call on this line and below. A simple string comparison is faster and more readable in this case.

Function checkFileActionPermission().

Actions
Copy link
 #1

Updated by Dmitry Dulepov over 11 years ago

Same in checkFolderActionPermission().

Actions
Copy link
 #2

Updated by Andreas Wolf over 11 years ago

  • Status changed from New to Accepted
  • Assignee set to Andreas Wolf
  • Target version set to 6.0.0-RC1
Actions
Copy link
 #3

Updated by Gerrit Code Review over 11 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/15400

Actions
Copy link
 #4

Updated by Gerrit Code Review over 11 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/15400

Actions
Copy link
 #5

Updated by Gerrit Code Review over 11 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/15400

Actions
Copy link
 #6

Updated by Anonymous over 11 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #7

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF