Project

General

Profile

Actions

Bug #42280

closed

Remove singleton for EXT:form Localization

Added by Christian Kuhn over 11 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Form Framework
Target version:
Start date:
2012-10-22
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.0
PHP Version:
5.3
Tags:
Complexity:
medium
Is Regression:
No
Sprint Focus:

Description

\TYPO3\CMS\Form\Localization is a singleton class with constructor
parameters. This is an antipattern and broken by design. As an effect
it leads to warnings in unit tests and makes the class unusable
with multiple files.

The patch removes the implementation of the singletonInterface, but
sets the default localization file as default parameter to keep
backwards compatibility.

Actions #1

Updated by Gerrit Code Review over 11 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/15886

Actions #2

Updated by Christian Kuhn over 11 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #3

Updated by Björn Jacob almost 9 years ago

  • Category changed from Form Framework to 1602
  • Is Regression set to No
Actions #4

Updated by Björn Jacob about 8 years ago

  • Category changed from 1602 to Form Framework
Actions #5

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF