Project

General

Profile

Actions

Bug #42969

closed

Recordy History is updated every time with a change in Images, even if there was no change

Added by Fabian over 11 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2012-11-14
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

If you safe a content element (for example Text&Images) and you use a dam image there is always an entry in the typo3 changelog created, even if you didn'T change anything.

Images: tx_dam_581 581


Files

dam_bug_syslog.jpg (31.9 KB) dam_bug_syslog.jpg Fabian , 2012-11-14 14:58
Actions #1

Updated by Lorenz Ulrich over 11 years ago

  • Status changed from New to Accepted

This is correct. Should be fixed.

Actions #2

Updated by Christian Weiske about 11 years ago

  • Assignee set to Christian Weiske

Steps to reproduce:
- TYPO3 backend
- Page module, edit Text+Image with linked DAM image
- List view, click the "records with clock" icon titled "Display change history"
- Colum "Differences" shows: Images: 23 tx_dam_23 (23 is red for old, tx_dam_23 is green for new)

Actions #3

Updated by Christian Weiske about 11 years ago

This is an issue in the TYPO3 core. It does not check if MM relations did change, it simply assumes that they did change. Or rather, it lacks the code to check this :)

The method responsible lacking the code is

t3lib_tcemain::compareFieldArrayWithCurrentAndUnset()

- it unsets all fields that did not change, and refuses to unset any MM-relation field. So the mm field - in our case tx_damttcontent_files - is seen as modified and thus logged.

You can reproduce this with a tiny extension created by the extension kickstarter:

  • create new extension with (old) kickstarter
  • extend existing table: tt_content
  • Field type: database relation
  • Activate "True M-M relations". This is the key here.
  • Create relation to table: pages or tt_content (does not matter)
  • Write and activate this extension

Edit the tt_content record, choose some pages or content elements in the new field, and save it 2 times. It will always be listed as changed:

MM related content elements 206 tt_content_206

Actions #4

Updated by Christian Weiske about 11 years ago

  • Assignee deleted (Christian Weiske)
Actions #5

Updated by Christian Weiske about 11 years ago

  • Project changed from 128 to TYPO3 Core
Actions #6

Updated by Mathias Schreiber over 9 years ago

  • Status changed from Accepted to Closed
  • TYPO3 Version set to 4.5
  • Is Regression set to No

won't fix

Actions

Also available in: Atom PDF