Project

General

Profile

Actions

Bug #43591

closed

Update page properties in a user-definded workspace clear the false cache

Added by Devid Messner over 11 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Workspaces
Target version:
Start date:
2012-12-04
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
6.0
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

When you update the page properties in a user-definded workspace then the dataHandler clear the cache of all pages with the pid "-1".
This make the backend very slow.

The problem is in the File: sysext/core/Classes/DataHandling/DataHander.php online 5605 -> here is a check necessary who check if you work in a workspace


Files

DataHandlerClearCache.diff (587 Bytes) DataHandlerClearCache.diff Devid Messner, 2012-12-13 15:41
DataHandlerClearCache.diff (587 Bytes) DataHandlerClearCache.diff Devid Messner, 2012-12-13 15:44
Actions #1

Updated by Tobias Liebig over 11 years ago

I looks like you already digged into the issue. Maybe.. Could you provide a patch?
Also, DataHander.php line 5605 is within "function insertDB". Is that the place you meant?

Actions #2

Updated by Tobias Liebig over 11 years ago

  • Project changed from TYPO3 Core to 624
  • Category deleted (Caching)

Workspace related issue.

Actions #3

Updated by Devid Messner over 11 years ago

sorry, my mistake.
The error is on line 5578 in the function "updateDB()"

The problem is that the function clear_cache($table, $id) delete also the cache from the parent pages, and when pid = -1 then was cleared the cache from all pages in other workspaces.

for me works the patch in attachment, but this is only a workaround and not the final solution.

Actions #4

Updated by Devid Messner over 11 years ago

sorry, i have send the false patch file.

Actions #5

Updated by Michel Tremblay about 11 years ago

I got the same performance problem when deleting pages in workspace. On a site with a thousand versioned pages, deleting a page can lead to more than 20 000 sql queries (and some ajax timeout...)

Should we add a condition filtering the '-1' pids directly in the clear_cache function (DataHandler.php).

How is cache handled in workspaces? Should we really clear cache at all?

Actions #6

Updated by Michael Stucki over 10 years ago

  • Category set to Workspaces
Actions #7

Updated by Michael Stucki over 10 years ago

  • Project changed from 624 to TYPO3 Core
  • Category changed from Workspaces to Workspaces
Actions #8

Updated by Mathias Schreiber about 9 years ago

  • Target version set to 7.5
Actions #9

Updated by Oliver Hader over 8 years ago

  • Status changed from New to Closed
  • Is Regression set to No

That was fixed for 6.2. Please open a new issue if you experience further difficulties with that. Thx

Actions

Also available in: Atom PDF