Bug #44231: config.compressJs wrong file path - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #44231

closed

config.compressJs wrong file path

Added by Torsten Fink almost 12 years ago. Updated over 10 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Category:

Content Rendering

Target version:

Start date:

2012-12-27

Due date:

% Done:

Estimated time:

1.00 h

TYPO3 Version:

6.0

PHP Version:

5.3

Tags:

Complexity:

easy

Is Regression:

Sprint Focus:

Description

As I wanted to enable config.compressJs i figured out that it doesn't work, and I found the problem here:

typo3/sysext/core/Classes/Page/PageRenderer.php:2196-2199
and again here
typo3/sysext/core/Classes/Page/PageRenderer.php:2234-2237

$file is used for the path to the file but must be $properties['file']
In 4.7 all is correct, in 6.0 not.

var_dump of $this->jsFiles shows the problem:

array (size=1)
  'typo3temp/compressor/merged-ec538a68e1733e504b710e5e7a092ff6.js' => 
    array (size=6)
      'file' => string 'typo3temp/compressor/merged-ec538a68e1733e504b710e5e7a092ff6-0bf83a0dbc17cd6de494cd8eaf72f7e7.js.gzip' (length=101)
      'type' => string 'text/javascript' (length=15)
      'section' => int 1
      'compress' => boolean true
      'forceOnTop' => boolean false
      'allWrap' => string '' (length=0)

Actions

Copy link

Updated by Torsten Fink almost 12 years ago

Maybe the compressJsFiles(typo3/sysext/core/Classes/Resource/ResourceCompressor.php:475) function could handle it like the compressCssFiles typo3/sysext/core/Classes/Resource/ResourceCompressor.php:332, same fix at another place.

Actions

Copy link

Updated by Oliver Hader almost 12 years ago

Thanks for analyzing this issue. Since you found a possible candidate to be changed, maybe you'd like to hand in a patch as well.
see http://wiki.typo3.org/Contribution_Walkthrough_Tutorials for further details or get back to me in case of questions - thx!

Actions

Copy link

Updated by Gerrit Code Review almost 12 years ago

Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17285

Actions

Copy link

Updated by Gerrit Code Review over 11 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17285

Actions

Copy link

Updated by Mateusz Wojtuła almost 11 years ago

I tried to reproduce this bug in TYPO3 6.2 but I couldn't.

I set:

1. Install -> All configuration -> [FE][compressionLevel] = 9

2. TypoScript:

page.includeJS {
  jquery = typo3conf/ext/template/jquery-ui-1.10.4/jquery-1.10.2.js
  uicore = typo3conf/ext/template/jquery-ui-1.10.4/ui/jquery.ui.core.js
}
config.compressJs = 1

3. .htaccess

<FilesMatch "\.js\.gzip$">
    AddType "text/javascript" .gzip
</FilesMatch>
<FilesMatch "\.css\.gzip$">
    AddType "text/css" .gzip
</FilesMatch>
AddEncoding gzip .gzip

All files are zipped and sent properly. Probably this problem is solved in this version of TYPO3.

Actions

Copy link