Bug #44585

FAL: file properties are not updated

Added by Stefan Froemken over 8 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Target version:
-
Start date:
2013-01-16
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.0
PHP Version:
5.3
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

Hello Core-Team,

I have my own FAL-Extension: fal_dropbox: https://github.com/froemken/fal_dropbox/
I create (NOT upload!) a new empty file called: hallo.txt
The new file will be created and listed perfectly. The size of this file is 0 bytes. This information is also added to sys_file.
Now I edit this file and write something in there and save this file.
The file was saved successfully and we return to our filelist.

BUT: The filesize keeps being 0 bytes.

After a long time of debugging I found out following:

In File.php -> Method: mergeIndexRecord() you have:

$this->properties = array_merge($this->properties, $recordData);

In $this->properties we have the correct values (bytes = 141)
In $recordData we have the old values from database.
After merging, the correct values are overwritten with the old values from the database.

Changing the values soved the problem:

$this->properties = array_merge($recordData, $this->properties);

Stefan

#1

Updated by Gerrit Code Review over 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17569

#2

Updated by Stefan Froemken over 8 years ago

Funny:

Switching "extended view" to on: filesize is wrong
Switching "extended view" to off: filesize is correct

#3

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17569

#4

Updated by Camelia M over 8 years ago

patch 2 works fine for me too on version 6.0.1

#5

Updated by Benni Mack over 8 years ago

Could you send it to the 6.0 branch as well?

#6

Updated by Stefan Froemken over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#7

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/18212

#8

Updated by Stefan Froemken over 8 years ago

  • Status changed from Under Review to Resolved
#9

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master_new has been pushed to the review server.
It is available at https://review.typo3.org/18633

#10

Updated by Christian Kuhn over 8 years ago

  • Status changed from Under Review to Resolved
#11

Updated by Benni Mack almost 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF