Bug #45834
closedDetection of curlProxyServer settings buggy on upgrade to 6.0
100%
Description
In #28344 "HTTP Request2" API was included. It supports detecting old school "curlProxyServer" settings and transfer these to the "new" setting under HTTP:
$proxyParts = explode(':', $GLOBALS['TYPO3_CONF_VARS']['SYS']['curlProxyServer'], 2); $GLOBALS['TYPO3_CONF_VARS']['HTTP']['proxy_host'] = $proxyParts[0]; $GLOBALS['TYPO3_CONF_VARS']['HTTP']['proxy_port'] = $proxyParts[1];
This code ended up in Core/Bootstrap::transferDeprecatedCurlSettings() after namespace and bootstrapification.
I have always set up this setting like this:
$GLOBALS['TYPO3_CONF_VARS']['SYS']['curlProxyServer'] = 'http://proxy:3128';
I guess the implementator of the transferDeprecatedCurlSettings was only thinking about the "proxy:3128" kind of syntax. I end up with:
$GLOBALS['TYPO3_CONF_VARS']['HTTP']['proxy_host'] = 'http' $GLOBALS['TYPO3_CONF_VARS']['HTTP']['proxy_port'] = '//proxy:3128;
Other than that, I would also auto-set ['HTTP']['adapter'] to 'curl' if legacy 'curlUse' = TRUE.
Updated by Gerrit Code Review over 11 years ago
- Status changed from New to Under Review
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18481
Updated by Gerrit Code Review over 11 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18481
Updated by Gerrit Code Review over 11 years ago
Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18481
Updated by Gerrit Code Review over 11 years ago
Patch set 1 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/22650
Updated by Gerrit Code Review over 11 years ago
Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/22651
Updated by Anonymous over 11 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset ad4742ca1c8d7e583dc8729ac1dff3e40a7f7104.
Updated by Ernesto Baschny over 10 years ago
- Status changed from Resolved to Accepted
- Is Regression set to No
This problem is not really resolved yet. I still get:
$GLOBALS['TYPO3_CONF_VARS']['HTTP']['proxy_host'] = 'http://proxy'
$GLOBALS['TYPO3_CONF_VARS']['HTTP']['proxy_port'] = '3128/;
which is equally wrong. I wonder how the patch that ended up in the core was tested??
Updated by Gerrit Code Review over 10 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31867
Updated by Gerrit Code Review over 10 years ago
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31879
Updated by Gerrit Code Review over 10 years ago
Patch set 1 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31880
Updated by Ernesto Baschny over 10 years ago
- Status changed from Under Review to Resolved
Applied in changeset 3dd60e20d44fdf102d14060bead85006135454bf.