Bug #45834

Detection of curlProxyServer settings buggy on upgrade to 6.0

Added by Ernesto Baschny about 8 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2013-02-25
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.0
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

In #28344 "HTTP Request2" API was included. It supports detecting old school "curlProxyServer" settings and transfer these to the "new" setting under HTTP:

    $proxyParts = explode(':', $GLOBALS['TYPO3_CONF_VARS']['SYS']['curlProxyServer'], 2);
    $GLOBALS['TYPO3_CONF_VARS']['HTTP']['proxy_host'] = $proxyParts[0];
    $GLOBALS['TYPO3_CONF_VARS']['HTTP']['proxy_port'] = $proxyParts[1];

This code ended up in Core/Bootstrap::transferDeprecatedCurlSettings() after namespace and bootstrapification.

I have always set up this setting like this:

$GLOBALS['TYPO3_CONF_VARS']['SYS']['curlProxyServer'] = 'http://proxy:3128';

I guess the implementator of the transferDeprecatedCurlSettings was only thinking about the "proxy:3128" kind of syntax. I end up with:

$GLOBALS['TYPO3_CONF_VARS']['HTTP']['proxy_host'] = 'http'
$GLOBALS['TYPO3_CONF_VARS']['HTTP']['proxy_port'] = '//proxy:3128;

Other than that, I would also auto-set ['HTTP']['adapter'] to 'curl' if legacy 'curlUse' = TRUE.


Related issues

Related to TYPO3 Core - Feature #28344: Include HTTP Request2 for better HTTP handlingClosedPhilipp Gampe2011-07-202011-07-25

Actions
Related to TYPO3 Core - Task #50506: Introduce use-statement for Utility-namespace in BootstrapClosed2013-07-29

Actions
Related to TYPO3 Core - Task #60622: Deprecate getUrl, curlProxyServer and encourage usage of HTTPRequestRejected2014-07-27

Actions
#1

Updated by Gerrit Code Review about 8 years ago

  • Status changed from New to Under Review

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18481

#2

Updated by Gerrit Code Review almost 8 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18481

#3

Updated by Gerrit Code Review almost 8 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18481

#4

Updated by Gerrit Code Review almost 8 years ago

Patch set 1 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/22650

#5

Updated by Gerrit Code Review almost 8 years ago

Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/22651

#6

Updated by Anonymous almost 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#7

Updated by Ernesto Baschny almost 7 years ago

  • Status changed from Resolved to Accepted
  • Is Regression set to No

This problem is not really resolved yet. I still get:

$GLOBALS['TYPO3_CONF_VARS']['HTTP']['proxy_host'] = 'http://proxy'
$GLOBALS['TYPO3_CONF_VARS']['HTTP']['proxy_port'] = '3128/;

which is equally wrong. I wonder how the patch that ended up in the core was tested??

#8

Updated by Gerrit Code Review almost 7 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31867

#9

Updated by Gerrit Code Review almost 7 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31879

#10

Updated by Gerrit Code Review almost 7 years ago

Patch set 1 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/31880

#11

Updated by Ernesto Baschny almost 7 years ago

  • Status changed from Under Review to Resolved
#12

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF