Project

General

Profile

Actions

Bug #45834

closed

Detection of curlProxyServer settings buggy on upgrade to 6.0

Added by Ernesto Baschny about 11 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2013-02-25
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.0
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

In #28344 "HTTP Request2" API was included. It supports detecting old school "curlProxyServer" settings and transfer these to the "new" setting under HTTP:

    $proxyParts = explode(':', $GLOBALS['TYPO3_CONF_VARS']['SYS']['curlProxyServer'], 2);
    $GLOBALS['TYPO3_CONF_VARS']['HTTP']['proxy_host'] = $proxyParts[0];
    $GLOBALS['TYPO3_CONF_VARS']['HTTP']['proxy_port'] = $proxyParts[1];

This code ended up in Core/Bootstrap::transferDeprecatedCurlSettings() after namespace and bootstrapification.

I have always set up this setting like this:

$GLOBALS['TYPO3_CONF_VARS']['SYS']['curlProxyServer'] = 'http://proxy:3128';

I guess the implementator of the transferDeprecatedCurlSettings was only thinking about the "proxy:3128" kind of syntax. I end up with:

$GLOBALS['TYPO3_CONF_VARS']['HTTP']['proxy_host'] = 'http'
$GLOBALS['TYPO3_CONF_VARS']['HTTP']['proxy_port'] = '//proxy:3128;

Other than that, I would also auto-set ['HTTP']['adapter'] to 'curl' if legacy 'curlUse' = TRUE.


Related issues 3 (0 open3 closed)

Related to TYPO3 Core - Feature #28344: Include HTTP Request2 for better HTTP handlingClosedPhilipp Gampe2011-07-202011-07-25

Actions
Related to TYPO3 Core - Task #50506: Introduce use-statement for Utility-namespace in BootstrapClosed2013-07-29

Actions
Related to TYPO3 Core - Task #60622: Deprecate getUrl, curlProxyServer and encourage usage of HTTPRequestRejected2014-07-27

Actions
Actions

Also available in: Atom PDF