Project

General

Profile

Actions
Copy link

Task #46435

closed

Various code issues in page tree ExtDirect code

Added by Dmitry Dulepov over 11 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Dmitry Dulepov
Category:
-
Target version:
-
Start date:
2013-03-19
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.0
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

TYPO3\CMS\Backend\Tree\Pagetree\Commands has several code issues:
  • name spaces in PHP comments contain double slashes and prevent code hinting
  • static functions use $this
  • getDomainName() fetches the row but does not check for the result of the operation
Actions
Copy link
 #1

Updated by Gerrit Code Review over 11 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19049

Actions
Copy link
 #2

Updated by Gerrit Code Review over 11 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19049

Actions
Copy link
 #3

Updated by Anonymous over 11 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #4

Updated by Gerrit Code Review over 11 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/19701

Actions
Copy link
 #5

Updated by Anonymous over 11 years ago

  • Status changed from Under Review to Resolved
Actions
Copy link
 #6

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF