Bug #47844: Query parameters of external link may get altered - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #47844

closed

Query parameters of external link may get altered

Added by Flummi no-lastname-given over 11 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Stanislas Rolland

Category:

RTE (rtehtmlarea + ckeditor)

Target version:

next-patchlevel

Start date:

2013-05-02

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

6.0

PHP Version:

Tags:

Complexity:

medium

Is Regression:

Sprint Focus:

Description

Asuming the website is running on http://domain.tld
When now putting a link as external URL in the link picker e.g. http://domain.tld/index.php?id=2&foo=123
the rte adds all parameters except id another time to the url.

I.E:

is changed after saving to:

When saving another time, the RTE changes it again to:

And so on until the links are very long and Typo3 crashes.

The problem seems to be in typo3/sysext/core/Classes/Html/RteHtmlParser.php
in line 680:

$href = ($attribArray['data-htmlarea-external'] ? $attribArray['href'] : $info['url']) . ($info['query'] ? ',0,' . $info['query'] : '');

I guess in line 1692 the class somehow assumes the link is a page link and sets the $info['query'] param, which then leeds to the error.

Actions

Copy link

Updated by Flummi no-lastname-given over 11 years ago

Possible Bugfix could be to change line 680 of typo3/sysext/core/Classes/Html/RteHtmlParser.php from-to:

- $href = ($attribArray['data-htmlarea-external'] ? $attribArray['href'] : $info['url']) . ($info['query'] ? ',0,' . $info['query'] : '');

+ $href = ($attribArray['data-htmlarea-external'] ? $attribArray['href'] : $info['url']) . (($info['query'] && !$attribArray['data-htmlarea-external']) ? ',0,' . $info['query'] : '');

Can someone confirm this? I don't realy know this class.

It worked for my situation, but I am not sure, if I affect other cases.

Actions

Copy link

Updated by Thorsten Kahler over 11 years ago

Status changed from New to Accepted

IMO your suggested patch interferes too late. The basic problem is that it's hardly possible to make a distinction between internal and external links if the current BE domain is used.

Actions

Copy link

Updated by Stanislas Rolland over 11 years ago

Flummi no-lastname-given wrote:

Possible Bugfix could be to change line 680 of typo3/sysext/core/Classes/Html/RteHtmlParser.php from-to:

- $href = ($attribArray['data-htmlarea-external'] ? $attribArray['href'] : $info['url']) . ($info['query'] ? ',0,' . $info['query'] : '');

+ $href = ($attribArray['data-htmlarea-external'] ? $attribArray['href'] : $info['url']) . (($info['query'] && !$attribArray['data-htmlarea-external']) ? ',0,' . $info['query'] : '');

Can someone confirm this? I don't realy know this class.

It worked for my situation, but I am not sure, if I affect other cases.

Yes. I think the analysis is correct.

Actions

Copy link

Updated by Stanislas Rolland over 11 years ago

Thorsten Kahler wrote:

IMO your suggested patch interferes too late. The basic problem is that it's hardly possible to make a distinction between internal and external links if the current BE domain is used.

Indeed. That is why the RTE link dialogue adds a data attribute on the link to make it explicit that the link is intended to be considered external.

Actions

Copy link

Updated by Stanislas Rolland over 11 years ago

Subject changed from Setting an external link with domain of the backend and some parameters is altered by typo3 to Query parameters of external link may get altered
Assignee set to Stanislas Rolland
Target version changed from 6.0.5 to next-patchlevel