Project

General

Profile

Actions

Bug #48404

closed

Form ignores/overrides a class for layout.elementWrap

Added by Marc Neuhaus almost 11 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Form Framework
Target version:
-
Start date:
2013-05-21
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

I'm currently trying to make the new Form rendering produce html markup for Bootstrap.
One thing that doesn't properly work is currently the elementWrap.

For example, if you try to set the layout of the elementWrap like this:

tt_content.mailform.20.layout {
    elementWrap (
        <div class="control-group">
            <element />
        </div>
    )
}

It will always ignore/override that class attribute and produce this instead:

<div class="csc-form-* csc-form-element csc-form-element-*">...</div>

This is caused by the ContainerElementView in line 61:

$childNode->setAttribute('class', $child->getElementWraps());

This line should should append the class instead of overriding it:

$class = strlen($childNode->getAttribute('class')) > 0 ? $childNode->getAttribute('class') . ' ' : '';
$class .= $child->getElementWraps();
$childNode->setAttribute('class', $class);
Actions #1

Updated by Gerrit Code Review almost 11 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20939

Actions #2

Updated by Gerrit Code Review over 10 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20939

Actions #3

Updated by Gerrit Code Review over 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/20939

Actions #4

Updated by Gerrit Code Review over 9 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/20939

Actions #5

Updated by Gerrit Code Review over 9 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35400

Actions #6

Updated by Anonymous over 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF