Bug #48404
closedForm ignores/overrides a class for layout.elementWrap
100%
Description
I'm currently trying to make the new Form rendering produce html markup for Bootstrap.
One thing that doesn't properly work is currently the elementWrap.
For example, if you try to set the layout of the elementWrap like this:
tt_content.mailform.20.layout { elementWrap ( <div class="control-group"> <element /> </div> ) }
It will always ignore/override that class attribute and produce this instead:
<div class="csc-form-* csc-form-element csc-form-element-*">...</div>
This is caused by the ContainerElementView in line 61:
$childNode->setAttribute('class', $child->getElementWraps());
This line should should append the class instead of overriding it:
$class = strlen($childNode->getAttribute('class')) > 0 ? $childNode->getAttribute('class') . ' ' : ''; $class .= $child->getElementWraps(); $childNode->setAttribute('class', $class);
Updated by Gerrit Code Review over 11 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20939
Updated by Gerrit Code Review over 11 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20939
Updated by Gerrit Code Review almost 10 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/20939
Updated by Gerrit Code Review almost 10 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/20939
Updated by Gerrit Code Review almost 10 years ago
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35400
Updated by Anonymous almost 10 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 144601322a4074ff61267c962bcd25a6e8da1a95.