Project

General

Profile

Actions

Bug #49396

closed

t3lib_utility_Mail::breakLinesForEmail cuts text wrong and discard rest of line

Added by Thorsten Krieger over 11 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2013-06-25
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.1
PHP Version:
5.3
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

This Line of a text mail for directmail

Mein Link auf eine News (Link: http://zzzzzzzzzzzzz.xxxxxxxxx.de/index.php?id=10&tx_ttnews%5Btt_news%5D=1&cHash=66f5af320da29b7ae1cda49047ca7358)

is cutted to
Mein Link auf eine News (Link: 

The bug ist in method breakLinesForEmail(). The counter $substrStart isn't incremented correctly.

You have to add this line

$substrStart++;

in this block
if ($spacePos !== FALSE) {
    // take everything up to last space-char
    $theLine = substr($substr, 0, $spacePos);
    $substrStart++;
} else {...}

See here in line 14: http://pastebin.com/3ejHhbfX

Actions #1

Updated by Jigal van Hemert over 11 years ago

  • Priority changed from Must have to Should have
  • Complexity set to easy
Actions #2

Updated by Gerrit Code Review over 11 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/21978

Actions #3

Updated by Tim Lochmüller over 11 years ago

Note: t3lib_utility_Mail is a deprecated class name. I fixed the MailUtility!

Actions #4

Updated by Gerrit Code Review over 11 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/21978

Actions #5

Updated by Gerrit Code Review over 11 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/21978

Actions #6

Updated by Gerrit Code Review over 11 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/21978

Actions #7

Updated by Gerrit Code Review over 11 years ago

Patch set 1 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/22677

Actions #8

Updated by Gerrit Code Review over 11 years ago

Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/22678

Actions #9

Updated by Tim Lochmüller over 11 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #10

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF