Project

General

Profile

Actions
Copy link

Feature #49477

closed

Submit icon ViewHelper for BE

Added by Charles Brunet almost 11 years ago. Updated over 8 years ago.

Status:
Rejected
Priority:
Should have
Assignee:
-
Category:
Fluid
Target version:
-
Start date:
2013-06-27
Due date:
% Done:

0%

Estimated time:
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Here is a be ViewHelper to render a submit button as an icon, like for 'save', 'save and close', 'save and view', and 'save and add'.

Files

SubmitIconViewHelper.php (3.22 KB) SubmitIconViewHelper.php PHP source Charles Brunet, 2013-06-27 22:32
Actions
Copy link
 #1

Updated by Alexander Opitz over 9 years ago

  • Status changed from New to Needs Feedback

Hi,

was this issue fixed or does it still exists?

Actions
Copy link
 #2

Updated by Charles Brunet over 9 years ago

I do not think such VH was integrated into the core of TYPO3 yet.

Actions
Copy link
 #3

Updated by Alexander Opitz over 9 years ago

Yes, but shouldn't adding an icon be done by CSS?

Actions
Copy link
 #4

Updated by Charles Brunet over 9 years ago

There actually is, in the Fluid extension, a be.buttons.icon ViewHelper. This works when the button is a link (for close of view actions for example). However, for 'save' action, the button need to submit the form. While it could be done with JavaScript, a better solution is to render the button as an input of type image. This is why I think a ViewHelper for that could be provided, to help building consistent interfaces between be modules.

Actions
Copy link
 #5

Updated by Alexander Opitz over 9 years ago

Ok, can you post this patch to Gerrit? For information see: http://wiki.typo3.org/CWT

Actions
Copy link
 #6

Updated by Alexander Opitz over 9 years ago

  • Project changed from 2559 to TYPO3 Core
  • Category set to Fluid
Actions
Copy link
 #7

Updated by Alexander Opitz over 9 years ago

Again my question, can you please post this patch to Gerrit?

Actions
Copy link
 #8

Updated by Gerrit Code Review over 9 years ago

  • Status changed from Needs Feedback to Under Review

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35619

Actions
Copy link
 #9

Updated by Gerrit Code Review over 9 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35619

Actions
Copy link
 #10

Updated by Gerrit Code Review over 9 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35619

Actions
Copy link
 #11

Updated by Benni Mack over 8 years ago

  • Status changed from Under Review to Rejected

will be done differently in v7 now.

Actions
Copy link

Also available in: Atom PDF