Bug #49499
closedTypoScriptFrontendController->initLLvars issue
100%
Description
(Every method I'll speak about are in TypoScriptFrontendController class)
Currently, >initLLvars is called from >getConfigArray, which is called from index_ts.php a few lines before ->settingLanguage.
Because of that and the fact that >initLLvars does not reinit ->languageDependencies before filling it can cause some issue, especially if english is not the default sys_language, when one uses >settingLanguage hooks to init language (instead of typoscript conditions)
- My website is French / English, and i'll visit the English version
- initLLVars fills ->languageDependencies with 'fr'
- ->settingLanguage hook properly sets the current language
- as it have to, the hook calls
>initLLVarsagain. Which does not empty >languageDependencies before adding nothing to it.
So, in this case, I end up with a ->languageDependencies = array('fr'), which results into french labels on my english website version.
Solutions are :- Move
>initLLVarscall somewhere in >settingLanguage (where it should belong, IMO). Problem here is that maybe>convPOSTCharsetwill have to be moved after the language init (it depends on >initLLvars because of charsets) so it could be difficult to test. - add "$this->languageDependencies = array()" at the beginning of ->initLLVars in order to ... init ll vars (what is what we should expect from it, no ?)
Updated by Popy no-lastname-given about 11 years ago
Yep. I just have to re-read the Git manual.
Should I provide multi-version patches ? (6.0, 6.1, trunk)
Updated by Jigal van Hemert about 11 years ago
- Category set to Localization
If the problem is present in master (6.2-dev) push a patch set for that version initially. Once it's merged the person who merged it will take care of the backports; unless you offer to help him/her and do the backports to earlier versions.
Updated by Popy no-lastname-given almost 11 years ago
Patch submitted to review : https://review.typo3.org/23529
Sorry for the delay
Updated by Gerrit Code Review almost 11 years ago
- Status changed from New to Under Review
Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23529
Updated by Gerrit Code Review almost 11 years ago
Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23529
Updated by Gerrit Code Review almost 11 years ago
Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23529
Updated by Gerrit Code Review almost 11 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/23529
Updated by Gerrit Code Review almost 11 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/23529
Updated by Gerrit Code Review almost 11 years ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/23529
Updated by Gerrit Code Review over 10 years ago
Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/23529
Updated by Gerrit Code Review over 10 years ago
Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/23529
Updated by Markus Klein over 10 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset dae88a2656e9480a6d4f0cc2d8b6c9a916e2101e.
Updated by Gerrit Code Review over 10 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27664
Updated by Gerrit Code Review over 10 years ago
Patch set 1 for branch TYPO3_6-0 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27665
Updated by Markus Klein over 10 years ago
- Status changed from Under Review to Resolved
Applied in changeset 4b44141a24a666206d1400733f5093aee526ec02.
Updated by Benni Mack almost 6 years ago
- Status changed from Resolved to Closed