Bug #49733

RTEmagic upgrade wizard: missing attributes

Added by Francois Suter about 8 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Should have
Category:
File Abstraction Layer (FAL)
Target version:
Start date:
2013-07-06
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.1
PHP Version:
5.3
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

When a magic image is created in the RTE with FAL, some "data-*" attributes are added to reference the original file. Example:

<img src="uploads/RTEmagicC_daneva.jpg" width="130" height="196" title="daneva.jpg" data-htmlarea-file-uid="1064" data-htmlarea-file-table="sys_file" alt="" />

According to Stanislas Rolland, this is used for updating the magic image in the RTE and for the click-enlarge feature in the frontend.

The magic image migration wizard should add these attributes too.

#1

Updated by Gerrit Code Review about 8 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/22019

#2

Updated by Gerrit Code Review about 8 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/22019

#3

Updated by Francois Suter about 8 years ago

You don't need to have a full TYPO3 installation to upgrade to test this patch. Here are some steps for testing (after having applied the patch):

1) pick some RTE magic image file in your uploads folder or add one if you have none. It should be named something like "uploads/RTEmagicC_foobar.jpg.jpg"
2) edit some tt_content element directly in a database tool and insert something like:

<img src="uploads/RTEmagicC_foobar.jpg.jpg" width="yyy" height="zzz" alt="" />

in the "bodytext" field.
3) update the sys_refindex index
4) go to the upgrade wizard, the Magic image update wizard should tell you that there's 1 link (at least) to update
5) run the Magic image update wizard. It should show the update queries.
6) check the content of the tt_content element in the database. The img tag should have been transformed to:
<img src="fileadmin/_migrated/RTE/RTEmagicC_foobar.jpg.jpg" data-htmlarea-file-uid="xxx" data-htmlarea-file-table="sys_file" width="yyy" height="zzz" alt="" />

#4

Updated by Gerrit Code Review about 8 years ago

Patch set 1 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/22285

#5

Updated by Francois Suter about 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#6

Updated by Benni Mack almost 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF