Actions
Task #49784
closedCleanup docblocks in DataHandler
Start date:
2013-07-08
Due date:
% Done:
100%
Estimated time:
TYPO3 Version:
6.1
PHP Version:
Tags:
Complexity:
no-brainer
Sprint Focus:
Description
The docblocks in DataHandler (the artist formerly known as TCEmain) are mostly no real docblocks, but have this form:
// variable description
/**
* @todo define visibility
*/
public $foobar
This is clearly not what we want and should be fixed: the comment should be moved into the docblock and there should be an @var annotation with the type.
Additionally, some variables that are clearly defined as "private" by a comment should be made protected - but this is potentially breaking.
Updated by Gerrit Code Review about 11 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/22119
Updated by Gerrit Code Review about 11 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/22119
Updated by Andreas Wolf about 11 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset b28734feae5ff546c882ab4af8964857f267fa90.
Updated by Riccardo De Contardi almost 7 years ago
- Status changed from Resolved to Closed
Actions