Bug #50038

space-before- and space-after- needs to be !important

Added by Ralf-Rene Schroeder over 7 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Content Rendering
Target version:
Start date:
2013-07-15
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.1
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

the dynamic CSS for space-befor- and space-after- needs to be !important;
because now a global definition of .csc-default
maybe witch is set in an own CSS file
overwrites every space the customer has set...

modifiing the following works for me (i think it would be usefull for all)...
typo3\sysext\css_styled_content\Classes\Controller\CssStyledContentController.php (row 1078 ff.)
________________________________________

if ($configuration['space'] === 'before') {
  $value = $constant + $this->cObj->data['spaceBefore'];
  $declaration = 'margin-top: ' . $value . 'px *!important*;';
} else {
  $value = $constant + $this->cObj->data['spaceAfter'];
  $declaration = 'margin-bottom: ' . $value . 'px *!important*;';
}

_________________________________________
#1

Updated by Ralf-Rene Schroeder over 7 years ago

sorry, i tried to mark it bold, and can't edit it now...
it should be: 'px !important;'

#2

Updated by Gerrit Code Review over 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/22346

#3

Updated by Gerrit Code Review over 7 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/22346

#4

Updated by Gerrit Code Review over 7 years ago

Patch set 1 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/22356

#5

Updated by Gerrit Code Review over 7 years ago

Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/22357

#6

Updated by Georg Ringer over 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#7

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF