Bug #50038
closedspace-before- and space-after- needs to be !important
100%
Description
the dynamic CSS for space-befor- and space-after- needs to be !important;
because now a global definition of .csc-default
maybe witch is set in an own CSS file
overwrites every space the customer has set...
modifiing the following works for me (i think it would be usefull for all)...
typo3\sysext\css_styled_content\Classes\Controller\CssStyledContentController.php (row 1078 ff.)
________________________________________
if ($configuration['space'] === 'before') { $value = $constant + $this->cObj->data['spaceBefore']; $declaration = 'margin-top: ' . $value . 'px *!important*;'; } else { $value = $constant + $this->cObj->data['spaceAfter']; $declaration = 'margin-bottom: ' . $value . 'px *!important*;'; }
_________________________________________
Updated by Ralf-Rene Schroeder over 11 years ago
sorry, i tried to mark it bold, and can't edit it now...
it should be: 'px !important;'
Updated by Gerrit Code Review over 11 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/22346
Updated by Gerrit Code Review over 11 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/22346
Updated by Gerrit Code Review over 11 years ago
Patch set 1 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/22356
Updated by Gerrit Code Review over 11 years ago
Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/22357
Updated by Georg Ringer over 11 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 6a6ab723ab0281f9a736db10ca1f658261082036.