Project

General

Profile

Actions
Copy link

Bug #50041

closed

Media content element does not work with youtube and https

Added by Jochem de Groot almost 11 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
6.2.0
Start date:
2013-07-15
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.1
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

If I add a media content element with a youtube url on a website which uses https, a blank box will be shown in the frontend while using Chrome (instead of the yt movie). It seems that a youtube url will always be prefixed with: 'http://www.youtube.com/v/', which is hard-coded in class.tslib_mediawizardcoreprovider.php. Other browsers will prompt a message that the https connection is partly secure, because of this.

I've added a patch as a suggestion. This prefixes the youtube url with http or https dependend on the current used protocol.

Regards,
-- Jochem

Files

class.tslib_mediawizardcoreprovider.patch (731 Bytes) class.tslib_mediawizardcoreprovider.patch Jochem de Groot, 2013-07-15 17:57
Actions
Copy link
 #1

Updated by Gerrit Code Review almost 11 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/22345

Actions
Copy link
 #2

Updated by Gerrit Code Review almost 11 years ago

Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/22375

Actions
Copy link
 #3

Updated by Gerrit Code Review almost 11 years ago

Patch set 1 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/22376

Actions
Copy link
 #4

Updated by Georg Ringer almost 11 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #5

Updated by Jochem de Groot almost 11 years ago

Hi Georg,

Thank you for resolving this issue!

Ps. Is there any change that this will be implemented the current LTS (4.5) as well?

Regards,
Jochem

Actions
Copy link
 #6

Updated by Fabian Auer over 10 years ago

Hi Georg,

thanks for your effort. Great!
But I think their is a small typo in your patch. Sorry I'm lagging knowledge to create a patch myself.
Line 132 it should be $http = 'https';

if (isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] == 'on') {
            $http = 'https';
         }

Otherwise the condition has no reason ;)

Actions
Copy link
 #7

Updated by Wolfangel Cyril about 10 years ago

i still encountered the same problem with 6.2 beta 4, is the patch have been published yet ?

Actions
Copy link
 #8

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF