Bug #50396
closed
RootlineUtility->enrichWithRelationFields issue with "group" type MM fields
100%
Description
I've been experiencing a recurring warning on a website, and I figured that something in RootlineUtility->enrichWithRelationFields is strange :
$loadDBGroup = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance('TYPO3\\CMS\\Core\\Database\\RelationHandler');
$loadDBGroup->start($pageRecord[$column], $configuration['foreign_table'], $configuration['MM'], $uid, 'pages', $configuration);
$relatedUids = $loadDBGroup->tableArray[$configuration['foreign_table']];
The code uses a "foreign_table" property, wich is not meant to exist in a "group" relation field.
Updated by Francois Suter over 10 years ago
- Status changed from New to Accepted
- Assignee set to Francois Suter
- Priority changed from -- undefined -- to Should have
- Target version set to next-patchlevel
- TYPO3 Version changed from 6.0 to 6.1
- Complexity set to easy
- Is Regression set to No
I have had this every now and then and finally took the time to track it down today. You're right that it's wrong to test only for "foreign_table". On top of improving that part, I think it's also good to check if the array to implode (some lines later) is really an array. I'll push a patch now.
Updated by Gerrit Code Review over 10 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29493
Updated by Gerrit Code Review over 10 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29493
Updated by Gerrit Code Review over 10 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/29493
Updated by Gerrit Code Review about 10 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/29493
Updated by Gerrit Code Review about 10 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/29493
Updated by Gerrit Code Review about 10 years ago
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32725
Updated by Francois Suter about 10 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 1b9081e68dd9c518e6aeb51555205cd33e3d1ce6.
Updated by Gerrit Code Review about 10 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32726
Updated by Francois Suter about 10 years ago
- Status changed from Under Review to Resolved
Applied in changeset 7eab013e3908ab8b949dadd68ff7af28bba0a004.
Updated by