Project

General

Profile

Actions

Bug #50912

closed

BackendUtility::viewOnClick() called with non-integer

Added by Oliver Hader over 10 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Miscellaneous
Target version:
-
Start date:
2013-08-08
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.1
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The origin is in DatabaseRecordList::makeControl() that tries to create a preview link with the page id "243#33163" - more strict checks will deny this request because it's not the expected integer value. Thus, BackendUtility::viewOnClick() is called with a string instead of an integer. This happens in the regular list module in the TYPO3 backend.

It's not critical if hooks and further processors use intval() on the argument, but is bad if methods expect the defined integer value.

Actions #1

Updated by Gerrit Code Review over 10 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/22951

Actions #2

Updated by Gerrit Code Review over 10 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/22951

Actions #3

Updated by Gerrit Code Review over 10 years ago

Patch set 1 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/23064

Actions #4

Updated by Sascha Egerer over 10 years ago

I don't understand the problem. Could you please add a testplan for that?

Actions #5

Updated by Oliver Hader over 10 years ago

  • Is Regression set to No

True... that happened in combination with other patches...
The origin is that BackendUtility::viewOnClick('123#456', ...) is called instead of having a uid in the first argument.

Actions #6

Updated by Oliver Hader over 10 years ago

  • Subject changed from Exception on listing content elements in workspaces to BackendUtility::viewOnClick() called with non-integer
Actions #7

Updated by Gerrit Code Review over 10 years ago

Patch set 2 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/23064

Actions #8

Updated by Gerrit Code Review over 10 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/22951

Actions #9

Updated by Gerrit Code Review over 10 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/22951

Actions #10

Updated by Oliver Hader over 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #11

Updated by Gerrit Code Review over 10 years ago

  • Status changed from Resolved to Under Review

Patch set 3 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/23064

Actions #12

Updated by Gerrit Code Review over 10 years ago

Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/24594

Actions #13

Updated by Oliver Hader over 10 years ago

  • Status changed from Under Review to Resolved
Actions #14

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF