Bug #50912: BackendUtility::viewOnClick() called with non-integer - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #50912

closed

BackendUtility::viewOnClick() called with non-integer

Added by Oliver Hader over 11 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Miscellaneous

Target version:

Start date:

2013-08-08

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

6.1

PHP Version:

5.3

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

The origin is in DatabaseRecordList::makeControl() that tries to create a preview link with the page id "243#33163" - more strict checks will deny this request because it's not the expected integer value. Thus, BackendUtility::viewOnClick() is called with a string instead of an integer. This happens in the regular list module in the TYPO3 backend.

It's not critical if hooks and further processors use intval() on the argument, but is bad if methods expect the defined integer value.

Actions

Copy link

Updated by Gerrit Code Review over 11 years ago

Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/22951

Actions

Copy link

Updated by Gerrit Code Review over 11 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/22951

Actions

Copy link

Updated by Gerrit Code Review over 11 years ago

Patch set 1 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/23064

Actions

Copy link

Updated by Sascha Egerer about 11 years ago

I don't understand the problem. Could you please add a testplan for that?

Actions

Copy link

Updated by Oliver Hader about 11 years ago

Is Regression set to No

True... that happened in combination with other patches...
The origin is that BackendUtility::viewOnClick('123#456', ...) is called instead of having a uid in the first argument.

Actions

Copy link