Bug #51004
closedFix file permission handling in BackendUserAuthentication
100%
Description
Take default TSConfig file permissions into account:
File permissions configured in User TSConfig,
are not taken into account, because the properties
from the getTSConfig method are returned in a
'properties' key of an array but the top level
array is used. Use getTSConfigProp instead.
Fix the bit wise check for old file permissions:
XOR the value is wrong because it gives the wrong
result if more bits are set. Use AND operation
to properly check if a specific bit is not set.
Check if the user is admin in getFilePermissionsForStorage()
Add tests to confirm the desired behaviour.
Updated by Gerrit Code Review about 11 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23037
Updated by Gerrit Code Review about 11 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23037
Updated by Gerrit Code Review about 11 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23037
Updated by Helmut Hummel about 11 years ago
- Subject changed from Take default TSConfig file permissions into account to Fix file permission handling in BackendUserAuthentication
Updated by Gerrit Code Review about 11 years ago
Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23037
Updated by Gerrit Code Review about 11 years ago
Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23037
Updated by Gerrit Code Review about 11 years ago
Patch set 1 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/23111
Updated by Gerrit Code Review about 11 years ago
Patch set 2 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/23111
Updated by Gerrit Code Review about 11 years ago
Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/23112
Updated by Gerrit Code Review about 11 years ago
Patch set 2 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/23112
Updated by Helmut Hummel about 11 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 329645ce21088e06b8e35e7bef985f32a08bf00f.
Updated by Gerrit Code Review about 11 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/23125
Updated by Gerrit Code Review about 11 years ago
Patch set 1 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/23126
Updated by Helmut Hummel about 11 years ago
- Status changed from Under Review to Resolved
Applied in changeset 3889f1a6d201b556c2f1bfba60985cf4e013b527.
Updated by Benni Mack almost 6 years ago
- Status changed from Resolved to Closed