Bug #51748
closed
PageRenderer->executePostRenderHook() does nothing when INT scripts are present
0%
Description
We have an extension that uses the following hook:
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_pagerenderer.php']['render-postProcess']
This hook works by providing a handful of variables that can be modified by reference, and which are subsequently are populated in the page template. We use it to add a custom <HTML> tag to the site, to support html5boilerplate-type approaches to cross-browser compatibility.
I've found that this particular hook has no effect when there are INT scripts on the page, and was able to trace it back to the fact that the hook itself gets called only when Javascript and CSS are rendered. For INT scripts, this happens long after the initial page markers have been populated in the template (see PageRenderer->renderJavaScriptAndCss()).
If we truly need to provide the post-INT-script-rendered javascript/css to the hook, I would call this "Hard or Nightmare" complexity. If we can settle for just providing the initial set of CSS/javascript to the hook (which will probably be fine in most use cases), this isn't too bad. It will still allow for modification of <html> tags and other header-related hackery, which I'm guessing is what this hook is used for most.
Updated by Gerrit Code Review about 11 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23623
Updated by Christian N over 10 years ago
Same issue confirmed in 6.1.7...
Patch is working...
It will still allow for modification of <html> tags and other header-related hackery, which I'm guessing is what this hook is used for most.
...which I'm guessing is what this hook is used for most, too :-)
Updated by Gerrit Code Review over 10 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/23623
Updated by Gerrit Code Review almost 10 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/23623
Updated by Anja Leichsenring almost 10 years ago
- Status changed from Under Review to New
- Is Regression set to No
Proposed change is rejected due to policy. Existing hooks are not to be moved or changed in order to maintain compatibility.
The solution for this problem: please introduce a signal at the place you need it, and use this.
Updated by Riccardo De Contardi over 7 years ago
- Status changed from New to Closed
Closed (Please look at the previous comment).
If you think that this is the wrong decision or there is work that still should be done, please reopen it or open a new issue with a reference to this one.
Thank you.