Bug #51936: ContentSlide works incorrect if last ContentElement is empty - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #51936

closed

ContentSlide works incorrect if last ContentElement is empty

Added by Robert Vock about 11 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Content Rendering

Target version:

Start date:

2013-09-12

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

6.2

PHP Version:

Tags:

Complexity:

no-brainer

Is Regression:

Sprint Focus:

Description

When using ContentSlide and the last content element in a column returns an empty string, the slide continues up in the page list, even when there are other content elements in the column.

TypoScript:

contentRight < styles.content.get
contentRight.select.where = colPos=1
contentRight.slide = -1

The 2-Byte fix is super simple.
In ContentContentObject.php change tmpValue to theValue in line 142:

} while ($again && ($slide && !strlen($theValue) && $slideCollectFuzzy || $slide && $slideCollect));

$tmpValue contains the content of the last processed content element. $theValue contains the html of the complete column.

This bug also affects previous TYPO3 Versions (6.1, 6.0, 4.5 etc)

Files

Bildschirmfoto_2013-09-12_um_10.48.05.png (28.3 KB) Bildschirmfoto_2013-09-12_um_10.48.05.png

Buggy columns

Robert Vock, 2013-09-12 10:55

Actions

Copy link

Updated by Philipp Gampe about 11 years ago

You you push your changes to gerrit? http://wiki.typo3.org/CWT

Actions

Copy link

Updated by Robert Vock about 11 years ago

I currently don't have my typo3 git setup at work. I can push in a few days, when I am at home and find the time

Actions

Copy link

Updated by Ernesto Baschny about 11 years ago

Category set to Content Rendering

Actions

Copy link

Updated by Gerrit Code Review about 11 years ago

Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23821

Actions

Copy link

Updated by Gerrit Code Review about 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/23821

Actions

Copy link

Updated by Gerrit Code Review about 10 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32928

Actions

Copy link

Updated by Gerrit Code Review about 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32928

Actions

Copy link

Updated by Gerrit Code Review about 10 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33482

Actions

Copy link

Updated by Gerrit Code Review about 10 years ago

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33482

Actions

Copy link

#10