Bug #52277

Epic #65814: Make Indexed search extbase plugin shine

indexed_search experimental mode returns no search results

Added by Jesper Mathiasen almost 6 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Indexed Search
Target version:
Start date:
2013-09-25
Due date:
% Done:

100%

TYPO3 Version:
6.1
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

When using the experimental extbase version of indexed_search a bug appears on line 173 in class "MysqlFulltextIndexHook" in "/indexed_search/classes/hook/MysqlFulltextIndexHook".

171 } elseif ($this->pObj->wholeSiteIdList >= 0) {
172    // Collecting all pages IDs in which to search; filtering out ALL pages that are not accessible due to enableFields. Does NOT look for "no_search" field!
173    $siteIdNumbers = \TYPO3\CMS\Core\Utility\GeneralUtility::intExplode(',', $this->pObj->wholeSiteIdList);
174    $idList = array();
175    foreach ($siteIdNumbers as $rootId) {
176        $cObj = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance('TYPO3\\CMS\\Frontend\\ContentObject\\ContentObjectRenderer');
177        /** @var \TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer $cObj */
178        $idList[] = $cObj->getTreeList($rootId, 9999, 0, 0, '', '') . $rootId;
179    }
180    $pageWhere = ' ISEC.page_id IN (' . implode(',', $idList) . ')';
181 }

$this->pObj->wholeSiteIdList on line 171 is null in this case as it is never defined in SearchController.php which is the controller used in experimental mode. This means that $idList in $pageWhere contains no page ids and no results are returned.

In addition It appears that several properties and/or methods called in MysqlFulltextIndexHook via $this->pObj are not set, however so far only the aforementioned leads to errors.

I checked Typo3 v 6.2 and it appears to be the same there.


Related issues

Related to TYPO3 Core - Bug #51347: Indexed Search (experimental) prblem Closed 2013-08-26

Associated revisions

Revision cff3ddc2 (diff)
Added by Tymoteusz Motylewski over 4 years ago

[BUGFIX] Indexed_search extbase plugin support for mysql fulltext search

Add three getters for IndexSearchRepository and SearchFormController
to have a common api for accessing data needed by FulltextIndexHook.

Unify the processing of $page_where as in one class it
was expected that it returns statement with 'AND' and in other without.

Unify the formatting of select statements in both classes to make
differences easier to spot (fix missing $wordSel statement
in the extbase plugin in the process).

Resolves: #65989
Resolves: #52277
Releases: master, 6.2
Change-Id: I9fcb86d44208e8fe6d205667f344022b0ad62505
Reviewed-on: http://review.typo3.org/38130
Reviewed-by: Tymoteusz Motylewski <>
Tested-by: Tymoteusz Motylewski <>

Revision 7977ac6b (diff)
Added by Tymoteusz Motylewski over 4 years ago

[BUGFIX] Indexed_search extbase plugin support for mysql fulltext search

Add three getters for IndexSearchRepository and SearchFormController
to have a common api for accessing data needed by FulltextIndexHook.

Unify the processing of $page_where as in one class it
was expected that it returns statement with 'AND' and in other without.

Unify the formatting of select statements in both classes to make
differences easier to spot (fix missing $wordSel statement
in the extbase plugin in the process).

Resolves: #65989
Resolves: #52277
Releases: master, 6.2
Change-Id: I9fcb86d44208e8fe6d205667f344022b0ad62505
Reviewed-on: http://review.typo3.org/38744
Reviewed-by: Tymoteusz Motylewski <>
Tested-by: Tymoteusz Motylewski <>

History

#1 Updated by Mathias Schreiber over 4 years ago

  • Target version set to 7.5

#2 Updated by Tymoteusz Motylewski over 4 years ago

  • Parent task set to #65814

#3 Updated by Gerrit Code Review over 4 years ago

  • Status changed from New to Under Review

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38130

#4 Updated by Gerrit Code Review over 4 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38743

#5 Updated by Gerrit Code Review over 4 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/38744

#6 Updated by Tymoteusz Motylewski over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Riccardo De Contardi almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF