Bug #52338

Task #49162: Rewrite install tool

Silent configuration generates endless redirect loop

Added by Ernesto Baschny over 7 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Install Tool
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

If I have some setting in my AdditionalConfiguration like:

$GLOBALS['TYPO3_CONF_VARS']['GFX']['im_v5effects'] = '1';

this will be always overwride whatever I have in my LocalConfiguration. Now the Install Tool has a "Auto-Configuration" which will try to set this setting to "-1" (in LocalConfiguration). And after doing that, it will redirect to itself. But then the AdditionalConfiguration will override this again and the game restarts.

Result is an endless loop.

This has to be detected somehow, because the current behavior is very touchy and you end up in an endless loop very easily.


Related issues

Related to TYPO3 Core - Task #52414: ext:install Break possible redirect loopClosed2013-10-01

Actions
#1

Updated by Ernesto Baschny over 7 years ago

In this case, the SilentConfigurationUpgradeService::setImageMagickDetailSettings is the one that calls for an redirect, because it always end up with a $changedValues.

#2

Updated by Christian Kuhn over 7 years ago

This probably happens for more values.

Solution is to not access $GLOBALS['TYPO3_CONF_VARS'], but to work with ConfigurationManager getLocalConfigurationValueByPath() and getConfigurationValueByPath()

#3

Updated by Christian Kuhn over 7 years ago

  • Parent task set to #49162
#4

Updated by Gerrit Code Review over 7 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24140

#5

Updated by Gerrit Code Review over 7 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24140

#6

Updated by Gerrit Code Review over 7 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24140

#7

Updated by Anja Leichsenring over 7 years ago

  • Status changed from Under Review to Resolved
#8

Updated by Riccardo De Contardi over 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF