Bug #52338: Silent configuration generates endless redirect loop - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #52338

closed

Task #49162: Rewrite install tool

Silent configuration generates endless redirect loop

Added by Ernesto Baschny about 11 years ago. Updated about 7 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Category:

Install Tool

Target version:

6.2.0

Start date:

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

6.2

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

If I have some setting in my AdditionalConfiguration like:

$GLOBALS['TYPO3_CONF_VARS']['GFX']['im_v5effects'] = '1';

this will be always overwride whatever I have in my LocalConfiguration. Now the Install Tool has a "Auto-Configuration" which will try to set this setting to "-1" (in LocalConfiguration). And after doing that, it will redirect to itself. But then the AdditionalConfiguration will override this again and the game restarts.

Result is an endless loop.

This has to be detected somehow, because the current behavior is very touchy and you end up in an endless loop very easily.

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Ernesto Baschny about 11 years ago

In this case, the SilentConfigurationUpgradeService::setImageMagickDetailSettings is the one that calls for an redirect, because it always end up with a $changedValues.

Actions

Copy link

Updated by Christian Kuhn about 11 years ago

This probably happens for more values.

Solution is to not access $GLOBALS['TYPO3_CONF_VARS'], but to work with ConfigurationManager getLocalConfigurationValueByPath() and getConfigurationValueByPath()

Actions

Copy link