Task #52360

Remove the closing PHP tag

Added by Chris topher over 4 years ago. Updated 4 months ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
-
Target version:
Start date:
2013-09-29
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
5.5
Tags:
Complexity:
Sprint Focus:

Description

It was decided to remove the closing PHP tag from the TYPO3 Core.

Go ahead and do so!


Related issues

Related to Coding Guidelines - Task #50145: Remove the closing PHP tag Resolved 2013-07-18
Related to Extension Builder - Bug #52428: Files must not have PHP closing tag ?> anymore Resolved 2013-10-01
Blocked by PHP_CodeSniffer - Task #52359: Adjust checks for closing PHP tag Resolved 2013-09-29

Associated revisions

Revision 77f29a3c (diff)
Added by Christian Kuhn over 4 years ago

[TASK] Remove closing PHP tags

Change-Id: Iaa92566c53301e49396fc9fb26b0b339c48d567b
Resolves: #52360
Releases: 6.2
Reviewed-on: https://review.typo3.org/24212
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

History

#1 Updated by Gerrit Code Review over 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24212

#2 Updated by Christian Kuhn over 4 years ago

find . -type d \( -path ./typo3/contrib/idna -o -path ./typo3/contrib/pear -o -path ./typo3/sysext/adodb/adodb -o -path ./typo3/sysext/openid/lib/php-openid -o -path ./typo3/sysext/openid/lib/php-openid/Auth \) -prune -o -name '*.php' -print | while read FILE; do tail -n1 $FILE | grep '^?>$' && sed -i '$ d' $FILE; done

find . -type f -name \*.php | while read FILE; do tail -n1 $FILE | grep '^$' && sed -i '$ d' $FILE; done

find . -type f -name \*.php | while read FILE; do tail -n1 $FILE | grep '^$' && sed -i '$ d' $FILE; done

find . -type f -name \*.php | while read FILE; do tail -n1 $FILE | grep '^$' && sed -i '$ d' $FILE; done

#3 Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24212

#4 Updated by Christian Kuhn over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#5 Updated by Riccardo De Contardi 4 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF