Project

General

Profile

Actions
Copy link

Bug #52386

closed

checkRecordInsertAccess should also look for ignoreRootLevelRestriction

Added by Benjamin Serfhos over 10 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
-
Target version:
-
Start date:
2013-09-30
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.1
PHP Version:
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

I made an extension where users should be able to insert an record in the root page (0).

I found the configuration ['ctrl']['security']['ignoreRootLevelRestriction'], which can be enabled. But the datahandler function checkRecordInsertAccess, does not check this configuration for the root level.

Can a checkup be inserted in the following file:
typo3/sysext/core/Classes/DataHandling/DataHandler.php

For fix, see: http://pastebin.com/KBhznsbu

Files

52386-TYPO3_6-1-7.patch (7.4 KB) 52386-TYPO3_6-1-7.patch Patch for TYPO3 6.1.7 Leon de Rijke, 2014-02-26 10:52
Actions
Copy link
 #1

Updated by Benjamin Serfhos over 10 years ago

In the pastebin, the fix is added on line 31-38.

Actions
Copy link
 #2

Updated by Benjamin Serfhos over 10 years ago

Yay, I found the way to push it to gerrit.

https://review.typo3.org/#/c/24164/

This should also be in the next releases of 6.2, if this is ok! =)

Please feedback! =)

Actions
Copy link
 #3

Updated by Markus Klein over 10 years ago

How do you accomplish that? A non-admin user usually can't access the Root page.
Or are you using some IRRE Elements configured to be stored at PID=0 via page TSconfig?

Actions
Copy link
 #4

Updated by Benjamin Serfhos over 10 years ago

I created a backend module that maintains these records and I just call the default add/edit functionality from TYPO3.

Configured in the TCA is the setting "'rootLevel' => TRUE," which should allow records to be added in the rootlevel.

Actions
Copy link
 #5

Updated by Gerrit Code Review over 10 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24166

Actions
Copy link
 #6

Updated by Gerrit Code Review over 10 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24166

Actions
Copy link
 #7

Updated by Gerrit Code Review over 10 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24166

Actions
Copy link
 #8

Updated by Gerrit Code Review over 10 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/24166

Actions
Copy link
 #9

Updated by Gerrit Code Review over 10 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/24166

Actions
Copy link
 #10

Updated by Benjamin Serfhos over 10 years ago

I would like to see this in 6.1 as well. Do I need to merge this issue with 6.1 branch or is this something I cannot do?

Actions
Copy link
 #11

Updated by Gerrit Code Review over 10 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/24166

Actions
Copy link
 #12

Updated by Gerrit Code Review about 10 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/24166

Actions
Copy link
 #13

Updated by Gerrit Code Review about 10 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/24166

Actions
Copy link
 #14

Updated by Leon de Rijke about 10 years ago

Benjamin Serfhos wrote:

I would like to see this in 6.1 as well. Do I need to merge this issue with 6.1 branch or is this something I cannot do?

Me too, as we want to use this in a current project. I applied Patch Set 8 to the tag TYPO3_6-1-7 and resolved the merge conflicts by hand. Please find the patch attached, just for your reference.

Actions
Copy link
 #15

Updated by Gerrit Code Review about 10 years ago

Patch set 2 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/24164

Actions
Copy link
 #16

Updated by Gerrit Code Review about 10 years ago

Patch set 1 for branch TYPO3_6-0 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27865

Actions
Copy link
 #17

Updated by Anonymous about 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 80 to 100
Actions
Copy link
 #18

Updated by Gerrit Code Review about 10 years ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch TYPO3_6-0 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27865

Actions
Copy link
 #19

Updated by Gerrit Code Review about 10 years ago

Patch set 3 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/24164

Actions
Copy link
 #20

Updated by Anonymous about 10 years ago

  • Status changed from Under Review to Resolved
Actions
Copy link
 #21

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF