Bug #52386
closed
checkRecordInsertAccess should also look for ignoreRootLevelRestriction
Added by Benjamin Serfhos over 10 years ago. Updated over 5 years ago.
100%
Description
I made an extension where users should be able to insert an record in the root page (0).
I found the configuration ['ctrl']['security']['ignoreRootLevelRestriction'], which can be enabled. But the datahandler function checkRecordInsertAccess, does not check this configuration for the root level.
Can a checkup be inserted in the following file:
typo3/sysext/core/Classes/DataHandling/DataHandler.php
For fix, see: http://pastebin.com/KBhznsbu
Files
| 52386-TYPO3_6-1-7.patch (7.4 KB) 52386-TYPO3_6-1-7.patch | Patch for TYPO3 6.1.7 | Leon de Rijke, 2014-02-26 10:52 |
Updated by Benjamin Serfhos over 10 years ago
In the pastebin, the fix is added on line 31-38.
Updated by Benjamin Serfhos over 10 years ago
Yay, I found the way to push it to gerrit.
https://review.typo3.org/#/c/24164/
This should also be in the next releases of 6.2, if this is ok! =)
Please feedback! =)
Updated by Markus Klein over 10 years ago
How do you accomplish that? A non-admin user usually can't access the Root page.
Or are you using some IRRE Elements configured to be stored at PID=0 via page TSconfig?
Updated by Benjamin Serfhos over 10 years ago
I created a backend module that maintains these records and I just call the default add/edit functionality from TYPO3.
Configured in the TCA is the setting "'rootLevel' => TRUE," which should allow records to be added in the rootlevel.
Updated by Gerrit Code Review over 10 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24166
Updated by Gerrit Code Review over 10 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24166
Updated by Gerrit Code Review over 10 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/24166
Updated by Gerrit Code Review over 10 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/24166
Updated by Gerrit Code Review over 10 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/24166
Updated by Benjamin Serfhos over 10 years ago
I would like to see this in 6.1 as well. Do I need to merge this issue with 6.1 branch or is this something I cannot do?
Updated by Gerrit Code Review over 10 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/24166
Updated by Gerrit Code Review about 10 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/24166
Updated by Gerrit Code Review about 10 years ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/24166
Updated by Leon de Rijke about 10 years ago
- File 52386-TYPO3_6-1-7.patch 52386-TYPO3_6-1-7.patch added
Benjamin Serfhos wrote:
I would like to see this in 6.1 as well. Do I need to merge this issue with 6.1 branch or is this something I cannot do?
Me too, as we want to use this in a current project. I applied Patch Set 8 to the tag TYPO3_6-1-7 and resolved the merge conflicts by hand. Please find the patch attached, just for your reference.
Updated by Gerrit Code Review about 10 years ago
Patch set 2 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/24164
Updated by Gerrit Code Review about 10 years ago
Patch set 1 for branch TYPO3_6-0 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27865
Updated by Anonymous about 10 years ago
- Status changed from Under Review to Resolved
- % Done changed from 80 to 100
Applied in changeset 7389b684945a1499947ba908f465f3f0d5f3a95a.
Updated by Gerrit Code Review about 10 years ago
- Status changed from Resolved to Under Review
Patch set 2 for branch TYPO3_6-0 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27865
Updated by Gerrit Code Review about 10 years ago
Patch set 3 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/24164
Updated by Anonymous about 10 years ago
- Status changed from Under Review to Resolved
Applied in changeset 06e5ad92251afd8b0cbd0f77cf9395116586f13a.
Updated by