Bug #53904

Content Elements Wizard (Tabs) - tab body shouldn't have fixed size

Added by Marcin Sągol about 6 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Target version:
Start date:
2013-11-24
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
5.4
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

If available content elements are rendered in tabs and we have some custom tabs configured then extra tabs are rendered outside tab content - see attached screen.

I think the tab content section should be fluid so it will match all tabs titles width or set it to 100% width so if will fill full area.

tabs_outside_body.jpg View (109 KB) Marcin Sągol, 2013-11-24 01:23

Associated revisions

Revision 6860bcc3 (diff)
Added by Marcin Sągol almost 6 years ago

[TASK] Remove fixed width for Content Element Wizard tabs content container

When using Content Element Wizard configured to render items with
tabs their body container has fixed width of 680px. This leads
to visual problems when using some extra tabs registered - their
titles are rendered outside body content. This patch removes
fixed width and some other styles that are not needed. For example
there are some styles for tables inside tab content but items are
rendered in lists not tables so we can remove them.

Change-Id: I1d749649ffa86cd2220460f1ebf4894aca98f4bc
Resolves: #53904
Releases: 6.2
Reviewed-on: https://review.typo3.org/26906
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Marcin S?gol
Tested-by: Marcin S?gol
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny

History

#1 Updated by Marcin Sągol about 6 years ago

The quick workaround might be to set min-width= XX and width=100% in styles of element with class: typo3-dyntabmenu-divs
This of course won't change much if we resize browser to small sizes where the wole content ara is very small but for "normal" usage it will be much better,

#2 Updated by Markus Klein about 6 years ago

Felix, can you please take a look at this?

#3 Updated by Ernesto Baschny almost 6 years ago

  • Status changed from New to Accepted
  • Assignee set to Ernesto Baschny

If I recall correctly, I have already some patch lying around on my laptop that touches / unifies this particular tabbed-table to the styles we have throughout other places (dynatabs). Will take a look!

#4 Updated by Ernesto Baschny almost 6 years ago

  • Assignee deleted (Ernesto Baschny)

Sorry, my cleanup won't solve this. But I feel that simply removing the "width: 680px" in the .typo3-dyntabmenu-divs would solve this issue. Feel free to upload a review request with this.

#5 Updated by Marcin Sągol almost 6 years ago

From what i see it can be changed/fixed without any modifications in current CSS. The fixed styles are hardcoded in:

typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php

we have there:

if ($this->config['renderMode'] == 'tabs') {
$this->doc->inDocStylesArray[] = '
.typo3-dyntabmenu-divs { background-color: #fafafa; border: 1px solid #adadad; width: 680px; }
.typo3-dyntabmenu-divs table { margin: 15px; }
.typo3-dyntabmenu-divs table td { padding: 3px; }
';
$code = $GLOBALS['LANG']->getLL('sel1', 1) . '<br /><br />' . $this->doc->getDynTabMenu($menuItems, 'new-content-element-wizard', FALSE, FALSE);
} else { ...

We can remove all $this->doc->inDocStylesArray[] part because we dont want fixed size and if renderMode is set to tabs there are no tables in tab body but lists so we dont need any styles for tables.

#6 Updated by Marcin Sągol almost 6 years ago

I'll send proposed patch for this.

#7 Updated by Gerrit Code Review almost 6 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26906

#8 Updated by Gerrit Code Review almost 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26906

#9 Updated by Anonymous almost 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#10 Updated by Riccardo De Contardi about 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF