Bug #53904
closed
Content Elements Wizard (Tabs) - tab body shouldn't have fixed size
Added by Marcin Sągol over 10 years ago.
Updated almost 7 years ago.
Category:
Backend User Interface
Description
If available content elements are rendered in tabs and we have some custom tabs configured then extra tabs are rendered outside tab content - see attached screen.
I think the tab content section should be fluid so it will match all tabs titles width or set it to 100% width so if will fill full area.
Files
The quick workaround might be to set min-width= XX and width=100% in styles of element with class: typo3-dyntabmenu-divs
This of course won't change much if we resize browser to small sizes where the wole content ara is very small but for "normal" usage it will be much better,
Felix, can you please take a look at this?
- Status changed from New to Accepted
- Assignee set to Ernesto Baschny
If I recall correctly, I have already some patch lying around on my laptop that touches / unifies this particular tabbed-table to the styles we have throughout other places (dynatabs). Will take a look!
- Assignee deleted (
Ernesto Baschny)
Sorry, my cleanup won't solve this. But I feel that simply removing the "width: 680px" in the .typo3-dyntabmenu-divs would solve this issue. Feel free to upload a review request with this.
From what i see it can be changed/fixed without any modifications in current CSS. The fixed styles are hardcoded in:
typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php
we have there:
if ($this->config['renderMode'] == 'tabs') {
$this->doc->inDocStylesArray[] = '
.typo3-dyntabmenu-divs { background-color: #fafafa; border: 1px solid #adadad; width: 680px; }
.typo3-dyntabmenu-divs table { margin: 15px; }
.typo3-dyntabmenu-divs table td { padding: 3px; }
';
$code = $GLOBALS['LANG']->getLL('sel1', 1) . '<br /><br />' . $this->doc->getDynTabMenu($menuItems, 'new-content-element-wizard', FALSE, FALSE);
} else { ...
We can remove all $this->doc->inDocStylesArray[] part because we dont want fixed size and if renderMode is set to tabs there are no tables in tab body but lists so we dont need any styles for tables.
I'll send proposed patch for this.
- Status changed from Accepted to Under Review
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
- Status changed from Resolved to Closed
Also available in: Atom
PDF