Project

General

Profile

Actions

Bug #54394

closed

Editing templavoila Template Objects not working

Added by Dragan Tomic almost 11 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Backend API
Target version:
Start date:
2013-12-13
Due date:
% Done:

100%

Estimated time:
0.10 h
TYPO3 Version:
6.1
PHP Version:
Tags:
Complexity:
no-brainer
Is Regression:
No
Sprint Focus:

Description

You can not edit templavoila Template Object if his preview icon is missing!


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #50827: Introduce handling of missing filesClosed2013-08-06

Actions
Actions #1

Updated by Dragan Tomic almost 11 years ago

You can not edit templavoila Template Object if his preview icon is missing!
Bug is in TYPO3\CMS\Backend\Utility\BackendUtility -> thumbCode() method.

In this part, if you don't get a file (file is missing) next line is trying to read File extension and throws an error!

$fileName = trim($uploaddir . '/' . $theFile, '/');
$fileObject = \TYPO3\CMS\Core\Resource\ResourceFactory::getInstance()->retrieveFileOrFolderObject($fileName);//if file is missing fileObject is empty
$fileExtension = $fileObject->getExtension(); // and this throws exception

Just need to double check if $fileObject is empty and then go further.

if($fileObject) {
$fileExtension = $fileObject->getExtension();
.......
}

Bug found in versions: 6.1.4-dev and 6.1.5

Actions #2

Updated by Markus Klein almost 11 years ago

  • Category changed from Backend User Interface to Backend API
  • Target version set to next-patchlevel

This is fixed in 6.2, but definitely missing in 6.1!

Actions #3

Updated by Gerrit Code Review almost 11 years ago

  • Status changed from New to Under Review

Patch set 1 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26446

Actions #4

Updated by Gerrit Code Review almost 11 years ago

Patch set 2 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26446

Actions #5

Updated by Gerrit Code Review almost 11 years ago

Patch set 3 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26446

Actions #6

Updated by Markus Klein over 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF