Task #54560

Epic #55070: Workpackages

Epic #55065: WP: Overall System Performance (Backend and Frontend)

Story #55078: Optimize PHP code performance in TYPO3 methods

Replace JavaScriptEncoder with json_encode()

Added by Michiel Roos almost 6 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Performance
Target version:
Start date:
2013-12-22
Due date:
% Done:

100%

TYPO3 Version:
6.2
PHP Version:
5.3
Tags:
Complexity:
no-brainer
Sprint Focus:

Description

The JavaScriptEncoder class is used a lot in the TYPO3 backend. It does expensive character conversions, character by character.

It would improve performance a lot if we use PHP native json_encode to do the encoding for us.

Please see attached screenshot.

JavaScriptEncoder_vs_jsonEncode.jpg View (39.4 KB) Michiel Roos, 2013-12-22 01:21


Related issues

Related to TYPO3 Core - Bug #55499: DebugUtility shows <\u00F2 instead of </ Closed 2014-01-31
Precedes TYPO3 Core - Task #55009: Replace $GLOBALS['LANG']->JScharCode() with \TYPO3\CMS\Core\Utility\GeneralUtility::encodeJavaScriptString() Closed 2014-01-15

Associated revisions

Revision 6cd6d3b3 (diff)
Added by Michiel Roos over 5 years ago

[TASK] Replace JavaScriptEncoder with json_encode()

The JavaScriptEncoder class is used a lot in the TYPO3 backend. It does
expensive character conversions, character by character.

It would improve performance a lot if we use PHP native json_encode to do
the encoding for us.

Change-Id: I3cb3bd6d887d49565fda496f9b13852cbeb9dfa1
Resolves: #54560
Releases: 6.2
Reviewed-on: https://review.typo3.org/26545
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Michiel Roos
Tested-by: Michiel Roos
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

History

#1 Updated by Gerrit Code Review almost 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26545

#2 Updated by Gerrit Code Review almost 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26545

#3 Updated by Gerrit Code Review almost 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26545

#4 Updated by Gerrit Code Review almost 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26545

#5 Updated by Gerrit Code Review almost 6 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26545

#6 Updated by Gerrit Code Review almost 6 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26545

#7 Updated by Gerrit Code Review almost 6 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26545

#8 Updated by Ernesto Baschny over 5 years ago

  • Parent task set to #52949

#9 Updated by Gerrit Code Review over 5 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26545

#10 Updated by Gerrit Code Review over 5 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26545

#11 Updated by Gerrit Code Review over 5 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26545

#12 Updated by Ernesto Baschny over 5 years ago

  • Target version changed from next-patchlevel to 6.2.0
  • Parent task changed from #52949 to #55078

#13 Updated by Gerrit Code Review over 5 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26545

#14 Updated by Michiel Roos over 5 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#15 Updated by Riccardo De Contardi almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF