Task #54560: Replace JavaScriptEncoder with json_encode() - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Task #54560

closed

Epic #55070: Workpackages

Epic #55065: WP: Overall System Performance (Backend and Frontend)

Story #55078: Optimize PHP code performance in TYPO3 methods

Replace JavaScriptEncoder with json_encode()

Added by Michiel Roos almost 11 years ago. Updated about 7 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Performance

Target version:

6.2.0

Start date:

2013-12-22

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

6.2

PHP Version:

5.3

Tags:

Complexity:

no-brainer

Sprint Focus:

Description

The JavaScriptEncoder class is used a lot in the TYPO3 backend. It does expensive character conversions, character by character.

It would improve performance a lot if we use PHP native json_encode to do the encoding for us.

Please see attached screenshot.

Files

JavaScriptEncoder_vs_jsonEncode.jpg (39.4 KB) JavaScriptEncoder_vs_jsonEncode.jpg

Michiel Roos, 2013-12-22 01:21

Related issues 2 (0 open — 2 closed)

Actions

Copy link

Updated by Gerrit Code Review almost 11 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26545

Actions

Copy link

Updated by Gerrit Code Review almost 11 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26545

Actions

Copy link

Updated by Gerrit Code Review almost 11 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26545

Actions

Copy link

Updated by Gerrit Code Review almost 11 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26545

Actions

Copy link

Updated by Gerrit Code Review almost 11 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26545

Actions

Copy link

Updated by Gerrit Code Review almost 11 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26545

Actions

Copy link

Updated by Gerrit Code Review almost 11 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26545

Actions

Copy link

Updated by Ernesto Baschny almost 11 years ago

Parent task set to #52949

Actions

Copy link

Updated by Gerrit Code Review almost 11 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26545

Actions

Copy link

#10

Updated by Gerrit Code Review almost 11 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26545

Actions

Copy link

#11

Updated by Gerrit Code Review almost 11 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26545

Actions

Copy link

#12

Updated by Ernesto Baschny almost 11 years ago

Target version changed from next-patchlevel to 6.2.0
Parent task changed from #52949 to #55078

Actions

Copy link

#13

Updated by Gerrit Code Review almost 11 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/26545

Actions

Copy link

#14