Project

General

Profile

Actions

Task #55009

closed

Epic #55575: Streamline JavaScript Code in the TYPO3 Backend

Replace $GLOBALS['LANG']->JScharCode() with \TYPO3\CMS\Core\Utility\GeneralUtility::encodeJavaScriptString()

Added by Michiel Roos about 10 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
Start date:
2014-01-15
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.3
Tags:
Complexity:
easy
Sprint Focus:

Description

The expensive JScharCode() calls (many calls to substr(), chr() and ord()) can be replaced with calls to \TYPO3\CMS\Core\Utility\GeneralUtility::encodeJavaScriptString()

Take care to add quotes around the result.


Related issues 1 (0 open1 closed)

Follows TYPO3 Core - Task #54560: Replace JavaScriptEncoder with json_encode()Closed2013-12-22

Actions
Actions #2

Updated by Daniel Siepmann about 10 years ago

  • Parent task set to #55575
Actions #3

Updated by Gerrit Code Review about 10 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27380

Actions #4

Updated by Gerrit Code Review about 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27380

Actions #5

Updated by Gerrit Code Review about 10 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27380

Actions #6

Updated by Gerrit Code Review about 10 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27380

Actions #7

Updated by Gerrit Code Review about 10 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27380

Actions #8

Updated by Michiel Roos about 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #9

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF